Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: polymake posets #3928

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: polymake posets #3928

wants to merge 2 commits into from

Conversation

benlorenz
Copy link
Member

@benlorenz benlorenz commented Jul 11, 2024

Extracted from #3819, but might need some things from there to work.

Todo:

  • tests
  • examples
  • do we need PartiallyOrderSetElement ? (create from constructor?)
  • can we properly visualize the top node?
  • make sure bottom and top are first and last node (for order polytope & co)?
  • what kind of input do we need? (currently: full graph, graph with rank map, matrix of covering relations, incidencematrix for set inclusions (like face lattices))

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 83.88%. Comparing base (686a746) to head (fb7200c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3928      +/-   ##
==========================================
- Coverage   83.99%   83.88%   -0.11%     
==========================================
  Files         591      592       +1     
  Lines       81386    81462      +76     
==========================================
- Hits        68359    68336      -23     
- Misses      13027    13126      +99     
Files Coverage Δ
src/Oscar.jl 68.35% <ø> (ø)
src/Combinatorics/PartiallyOrderedSet/functions.jl 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants