Support Arm64 (and apple M1) #609

mseri · 2022-04-14T09:32:00Z

Resubmitting as requested

to try this PR on mac use

opam pin -n git+https://github.com/mseri/owl.git#arm64 --with-version=1.1.0
PKG_CONFIG_PATH="/opt/homebrew/opt/openblas/lib/pkgconfig" opam install owl.1.1.0

Signed-off-by: Marcello Seri <[email protected]>

ryanrhymes · 2022-04-14T13:11:04Z

@jzstark can you test on both the mac and thinkpad. It seems I have some compilation issue on one of my thinkpads. I will also dig a bit deeper.

jzstark · 2022-04-14T13:27:12Z

I tried compiling the code with this PR on my Ubuntu 20.04 desktop, and there are indeed errors and warnings; the current master branch compile normally. Part of the log are pasted below.

File "src/owl/dune", line 56, characters 3-17:
56 |    owl_core_utils
        ^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/core/owl_core_utils.c:6:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
src/owl/core/owl_core_utils.c:216:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 75, characters 3-22:
75 |    owl_fftpack_float32
        ^^^^^^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/fftpack/owl_fftpack_float32.c:8:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 76, characters 3-22:
76 |    owl_fftpack_float64
        ^^^^^^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/fftpack/owl_fftpack_float64.c:8:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 61, characters 3-28:
61 |    owl_ndarray_contract_stub
        ^^^^^^^^^^^^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/core/owl_ndarray_contract_stub.c:6:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 59, characters 3-24:
59 |    owl_matrix_check_stub
        ^^^^^^^^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/core/owl_matrix_check_stub.c:6:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 60, characters 3-23:
60 |    owl_matrix_swap_stub
        ^^^^^^^^^^^^^^^^^^^^
...

ryanrhymes · 2022-04-14T13:31:57Z

I tried compiling the code with this PR on my Ubuntu 20.04 desktop, and there are indeed errors and warnings; the current master branch compile normally. Part of the log are pasted below.

File "src/owl/dune", line 56, characters 3-17:
56 |    owl_core_utils
        ^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/core/owl_core_utils.c:6:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
src/owl/core/owl_core_utils.c:216:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 75, characters 3-22:
75 |    owl_fftpack_float32
        ^^^^^^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/fftpack/owl_fftpack_float32.c:8:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 76, characters 3-22:
76 |    owl_fftpack_float64
        ^^^^^^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/fftpack/owl_fftpack_float64.c:8:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 61, characters 3-28:
61 |    owl_ndarray_contract_stub
        ^^^^^^^^^^^^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/core/owl_ndarray_contract_stub.c:6:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 59, characters 3-24:
59 |    owl_matrix_check_stub
        ^^^^^^^^^^^^^^^^^^^^^
In file included from src/owl/core/owl_core.h:9,
                 from src/owl/core/owl_matrix_check_stub.c:6:
src/owl/core/owl_macros.h:90:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
File "src/owl/dune", line 60, characters 3-23:
60 |    owl_matrix_swap_stub
        ^^^^^^^^^^^^^^^^^^^^
...

Thanks to confirm, I saw the same error. Removing that option fixed some errors but there are still some other errors. Probably the main issue is using different version of OCaml. I will try to switch to another version later.

mseri · 2022-04-14T13:33:39Z

Super. I guess it depends on the compiler used. Does this new commit fix it?

mseri · 2022-04-14T13:38:20Z

Where does -Wno-logical-op-parentheses come from? I did not add that anywhere

jzstark · 2022-04-14T13:39:17Z

This fixes a lot of warnings, but the error is still there. (I use OCaml 4.14 and dune 3.0.3.)

dune build @install
File "src/owl/dune", line 56, characters 3-17:
56 |    owl_core_utils
        ^^^^^^^^^^^^^^
src/owl/core/owl_core_utils.c:216:6: error: #elif with no expression
cc1: warning: unrecognized command line option ‘-Wno-logical-op-parentheses’
make: *** [Makefile:9: build] Error 1

ryanrhymes · 2022-04-14T13:46:09Z

-Wno-logical-op-parentheses

From here

owl/src/owl/config/configure.ml

Line 115 in eead31f

then [ "-Wno-logical-op-parentheses" ]

Actually, we can simply remove get_devmode_cflags, and move [ "-Wall"; "-pedantic"; "-Wextra"; "-Wunused" ] to

owl/src/owl/config/configure.ml

Line 253 in eead31f

[]

src/owl/config/configure.ml

mseri · 2022-04-14T20:42:39Z

I'll make the change, but that line is there from before my PR. It is strange that it fails now and was not failing before. It would be interesting to understand why

They break the compilation with some c compilers. See owlbarn#609 Signed-off-by: Marcello Seri <[email protected]>

mseri · 2022-04-15T07:11:26Z

At some point we should probably get rid of (or rewrite) default_gcc_path (outdated in most systems) and openblas_default (can mix up x86_64 and arm64 libraries on mac for people using homebrew, which uses the old path for x86_64 and a new one, I think /opt/local, for arm64 libraries)

Signed-off-by: Marcello Seri <[email protected]>

mseri · 2022-04-28T20:28:30Z

I have created the parent PR on eigen, with these the build should work fine on both M1 and x86_64. I am still having some linking issues with eigen since the last macos update.

Signed-off-by: Marcello Seri <[email protected]>

mseri · 2022-04-29T07:44:00Z

I can no-longer test this, eigen fails to build for me with the lastest macos compiler upgrade

mseri · 2022-05-02T08:16:20Z

Update: I have made a new PR to update the current eigen.0.3.0 build (not using recent dune features which seem to produce linking errors) and backported a fix from eigen to build on clang 3.9.
The new PR is here: owlbarn/eigen#36
With that one I seem to be able to use eigen and owl on both macos x86_64 and macos M1

Debian now ships lapacke separately, requiring new set of flags for the linking to work. This uses pkg-config to improve the detection of these flags. Furthermore this commit adds a workaround to solve the issue with libgcc11_s not found, which will not be addressed upstream in homebrew for the time being. Signed-off-by: Marcello Seri <[email protected]>

mseri · 2022-08-17T09:08:03Z

Any news on this? I have been using it fine on various different mac and linux intel and mac ARM cpus for weeks

tachukao · 2022-08-18T16:51:10Z

opam pin -n git+https://github.com/mseri/owl.git#arm64 --with-version=1.1.0
PKG_CONFIG_PATH="/opt/homebrew/opt/openblas/lib/pkgconfig" opam install owl.1.1.0

This worked for me on a new M1 mac

Zeta611 · 2022-09-06T13:02:58Z

I can confirm that this works perfectly well with my M1 Mac on macOS Monterey.

samoht · 2022-10-02T14:11:59Z

I've got:

# (cd _build/default && /Users/thomas/git/hdf5-ocaml/_opam/bin/ocamlmklib.opt -g -o src/owl/owl_stubs src/owl/SFMT.o src/owl/airy.o src/owl/airyf.o src/owl/bdtr.o src/owl/beta.o src/owl/btdtr.o src/owl/cbrt.o src/owl/chbevl.o src/owl/chbevlf.o src/owl/chdtr.o src/owl/const.o src/owl/constf.o src/owl/dawsn.o src/owl/dawsnf.o src/owl/ellie.o src/owl/ellik.o src/owl/ellpe.o src/owl/ellpj.o src/owl[...]
# ld: file not found: @rpath/libquadmath.0.dylib for architecture arm64

mseri · 2022-10-02T14:26:27Z

Something is off with homebrew. For a similar issue with libgcc one needs to manually fix some paths or create special symlinks

mseri · 2022-10-02T14:27:07Z

src/owl/config/configure.ml

+        ]
+  in
+  (* homebrew M1 issue workaround, works only if users use the default homebrew path *)
+  let libs =


@samoht something like this one here

src/owl/config/configure.ml

Co-authored-by: Thomas Gazagnaire <[email protected]>

Signed-off-by: Marcello Seri <[email protected]>

nilsbecker · 2023-01-25T09:49:50Z

On my Intel mac the installation procedure in the top post is not working. macos 12.6.2. my homebrew installation of openblas says

For compilers to find openblas you may need to set:
  export LDFLAGS="-L/usr/local/opt/openblas/lib"
  export CPPFLAGS="-I/usr/local/opt/openblas/include"

For pkg-config to find openblas you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/openblas/lib/pkgconfig"

so the path is a different one. also, my gfortran libquadmath is in /usr/local/gfortran/lib

nilsbecker · 2023-01-25T09:51:14Z

Needless to say, the current opam version of owl is also not building.

See owlbarn#636 Signed-off-by: Marcello Seri <[email protected]>

anmonteiro · 2023-10-31T21:30:28Z

This is still failing for me with:

   > clang-11: error: the clang compiler does not support '-mcpu=apple-m1'

src/aeos/config/configure.ml

src/owl/config/configure.ml

mseri · 2023-10-31T21:58:36Z

Try now: -march=native is supported on mac arm for recent enough macos, I modified the code to use that

anmonteiro · 2023-10-31T22:02:37Z

Thank you, it does work now.

tmcgilchrist · 2024-01-15T02:27:57Z

Running this on an M3 macOS Sonoma 14.2.1 I get this error:

File "_none_", line 1:             
Error: No implementations provided for the following modules:
         Unix referenced from /Users/tsmc/code/ocaml/par-matmul-profiling/_opam/lib/owl-base/owl_base.cmxa(Owl_utils),
           /Users/tsmc/code/ocaml/par-matmul-profiling/_opam/lib/owl-base/owl_base.cmxa(Owl_log),
           /Users/tsmc/code/ocaml/par-matmul-profiling/_opam/lib/owl-base/owl_base.cmxa(Owl_io)

Test case setting up https://github.com/ghennequin/par-matmul-profiling. If you rebase including commits from #630 then it works well. To test try using:

opam pin -n git+https://github.com/tmcgilchrist/owl.git#arm64 --with-version=1.1.0
PKG_CONFIG_PATH="/opt/homebrew/opt/openblas/lib/pkgconfig" opam install owl.1.1.0

What is required to get this merged and a release of Owl for MacOS/ARM64 onto opam?

mseri · 2024-03-05T11:09:46Z

I have merged main to fix the merge conflicts

tmcgilchrist · 2024-04-15T07:03:41Z

@jzstark any progress on getting ARM64 support merged?

nilsbecker · 2024-04-15T09:00:41Z

This would be a good sign that owl is indeed being actively maintained, now that the project conclusion was reverted.

mseri added 9 commits April 12, 2022 18:17

Progress towards ARM64 support

b9d1ccd

Signed-off-by: Marcello Seri <[email protected]>

Re-introduce Ofast flag

8044bb5

Signed-off-by: Marcello Seri <[email protected]>

unit_signal: fix test

b5db632

Signed-off-by: Marcello Seri <[email protected]>

Update architecture detection

ac2e0d7

Signed-off-by: Marcello Seri <[email protected]>

ocamlformat

7a3c434

Signed-off-by: Marcello Seri <[email protected]>

fixup! Update architecture detection

efc51a1

Improve architecture and os detection

48a8b0e

Signed-off-by: Marcello Seri <[email protected]>

config: cleanup unused open

ab17a40

Signed-off-by: Marcello Seri <[email protected]>

reintroduce -mfpmath=sse on x86_64

7f4cc77

Signed-off-by: Marcello Seri <[email protected]>

ryanrhymes added the enhancement label Apr 14, 2022

owl_macros.h: remove empty if

69c7e38

ryanrhymes reviewed Apr 14, 2022

View reviewed changes

src/owl/config/configure.ml Outdated Show resolved Hide resolved

owl/configure: remove devmode cflags

0b64902

They break the compilation with some c compilers. See owlbarn#609 Signed-off-by: Marcello Seri <[email protected]>

mseri mentioned this pull request Apr 28, 2022

build: add architecture dependent configuration owlbarn/eigen#35

Open

owl_core_utils: Fix empty elif

729cf00

Signed-off-by: Marcello Seri <[email protected]>

Cleanup arch detection code

2537f1b

Signed-off-by: Marcello Seri <[email protected]>

mseri mentioned this pull request May 5, 2022

Installation Fails - Apple M1 Chip Related? #611

Closed

mseri commented Oct 2, 2022

View reviewed changes

samoht reviewed Oct 2, 2022

View reviewed changes

src/owl/config/configure.ml Outdated Show resolved Hide resolved

Update src/owl/config/configure.ml

954f498

Co-authored-by: Thomas Gazagnaire <[email protected]>

mseri mentioned this pull request Nov 4, 2022

Painful installation on MacOS #625

Open

mseri added 2 commits January 9, 2023 10:31

configurator: drop unnecessary dependency on stdio

00e9d33

Signed-off-by: Marcello Seri <[email protected]>

Merge remote-tracking branch 'upstream/main' into arm64

9420a4c

ellieyhcheng mentioned this pull request Jan 25, 2023

Error Building on Mac M1 IBM/probzelus#8

Open

jcreinhold mentioned this pull request Mar 15, 2023

add additional environment variables and add libraries/flags to linki… #636

Closed

add @jcreinhold patch for nonstandard setups

fac5927

See owlbarn#636 Signed-off-by: Marcello Seri <[email protected]>

mseri commented Oct 31, 2023

View reviewed changes

src/aeos/config/configure.ml Outdated Show resolved Hide resolved

Update src/aeos/config/configure.ml

8820211

mseri commented Oct 31, 2023

View reviewed changes

src/owl/config/configure.ml Outdated Show resolved Hide resolved

Update src/owl/config/configure.ml

d3b5390

Merge remote-tracking branch 'upstream/main' into arm64

efc7508

mseri mentioned this pull request Mar 6, 2024

Enable github actions for testing #658

Merged

jzstark merged commit 5d2f6d1 into owlbarn:main May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Arm64 (and apple M1) #609

Support Arm64 (and apple M1) #609

mseri commented Apr 14, 2022 •

edited

Loading

ryanrhymes commented Apr 14, 2022

jzstark commented Apr 14, 2022

ryanrhymes commented Apr 14, 2022

mseri commented Apr 14, 2022

mseri commented Apr 14, 2022

jzstark commented Apr 14, 2022

ryanrhymes commented Apr 14, 2022

mseri commented Apr 14, 2022

mseri commented Apr 15, 2022

mseri commented Apr 28, 2022

mseri commented Apr 29, 2022

mseri commented May 2, 2022

mseri commented Aug 17, 2022

tachukao commented Aug 18, 2022

Zeta611 commented Sep 6, 2022

samoht commented Oct 2, 2022 •

edited

Loading

mseri commented Oct 2, 2022

mseri Oct 2, 2022

nilsbecker commented Jan 25, 2023

nilsbecker commented Jan 25, 2023

anmonteiro commented Oct 31, 2023

mseri commented Oct 31, 2023 •

edited

Loading

anmonteiro commented Oct 31, 2023

tmcgilchrist commented Jan 15, 2024 •

edited

Loading

mseri commented Mar 5, 2024

tmcgilchrist commented Apr 15, 2024

nilsbecker commented Apr 15, 2024

Support Arm64 (and apple M1) #609

Support Arm64 (and apple M1) #609

Conversation

mseri commented Apr 14, 2022 • edited Loading

ryanrhymes commented Apr 14, 2022

jzstark commented Apr 14, 2022

ryanrhymes commented Apr 14, 2022

mseri commented Apr 14, 2022

mseri commented Apr 14, 2022

jzstark commented Apr 14, 2022

ryanrhymes commented Apr 14, 2022

mseri commented Apr 14, 2022

mseri commented Apr 15, 2022

mseri commented Apr 28, 2022

mseri commented Apr 29, 2022

mseri commented May 2, 2022

mseri commented Aug 17, 2022

tachukao commented Aug 18, 2022

Zeta611 commented Sep 6, 2022

samoht commented Oct 2, 2022 • edited Loading

mseri commented Oct 2, 2022

mseri Oct 2, 2022

Choose a reason for hiding this comment

nilsbecker commented Jan 25, 2023

nilsbecker commented Jan 25, 2023

anmonteiro commented Oct 31, 2023

mseri commented Oct 31, 2023 • edited Loading

anmonteiro commented Oct 31, 2023

tmcgilchrist commented Jan 15, 2024 • edited Loading

mseri commented Mar 5, 2024

tmcgilchrist commented Apr 15, 2024

nilsbecker commented Apr 15, 2024

mseri commented Apr 14, 2022 •

edited

Loading

samoht commented Oct 2, 2022 •

edited

Loading

mseri commented Oct 31, 2023 •

edited

Loading

tmcgilchrist commented Jan 15, 2024 •

edited

Loading