Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable github actions for testing #658

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

mseri
Copy link
Member

@mseri mseri commented Mar 6, 2024

This tests separately the three packages, should catch packaging issues before releases are made. It also tests the arm builds for macos (they will fail until #609 is merged)

This tests separately the three packages, should catch
packaging issues before releases are made. It also
tests the arm builds for macos.

Signed-off-by: Marcello Seri <[email protected]>
@mseri mseri changed the title Enable github actions to test owk Enable github actions for testing Mar 6, 2024
@jzstark
Copy link
Collaborator

jzstark commented Mar 7, 2024

Thanks a lot for adding test for various platforms other than Ubuntu. The test shows that building on most macos systems fails. Besides the main workflow based on ubuntu-latest, I have also tested a Github action on macos-latest, where Owl builds well. Perhaps this mac.yml would be helpful. I believe in the tests we should build Owl from source instead of opam repository, where the Owl code is actually outdated.

@mseri
Copy link
Member Author

mseri commented Mar 7, 2024 via email

@mseri
Copy link
Member Author

mseri commented Mar 7, 2024

I looked at the mac script, it works only because it is restricted to ocaml 5.1, I think if you enable 4.14 or earlier you should see the same failures. The libquadmath failure should be fixed by the same pr that fixes macos arm64.

The main advantage of using setup-ocaml in the way suggested here is that it will ensure that the depext, opam files and tests are properly setup for release and should work properly for the users that want to use the dev version.

@jzstark
Copy link
Collaborator

jzstark commented Mar 8, 2024

True, this issue arm64 issue is one that requires fixing. Thanks a lot for your help, and I'll take a look at both PRs soon.

@tmcgilchrist
Copy link

Looks like a reasonable change. 👍🏻

@jzstark jzstark merged commit d957bd8 into owlbarn:main May 3, 2024
5 of 12 checks passed
@mseri mseri deleted the github_actions branch May 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants