[feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 #1116

hosy · 2022-04-05T13:20:05Z

Description

With Apple Silicon M1 it was no longer possible to build the app for Simulator.
Because we need to provide additional architecture, we using new OpenSSL as Swift package.
In the context of this, the code was migrated to OpenSSL 1.1.1.

migrated code to new OpenSSL 1.1.1 API
using OpenSSL Swift Package

Related Issue

Motivation and Context

Build against all architectures, using the latest OpenSSL version.

How Has This Been Tested?

Build and run on all platforms iOS, Mac Catalyst, Simulator, Device
Add a new account
Check if certificate output is the same as before migrating

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
Added an issue with details about all relevant changes in the iOS documentation repository.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
Added changelog files for the fixed issues in folder changelog/unreleased

QA

Checklist: #1116 (comment)

Reports

(1) Build with Xcode 12.5 [feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 #1116 (comment) [WONT FIX]
(2) Changes in certificates [feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 #1116 (comment)

- using OpenSSL Package

CLAassistant · 2022-04-05T13:20:10Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Matthias Hühne
❌ felix-schwarz

Matthias Hühne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

jesmrec · 2022-04-07T11:58:39Z

QA checks:

Add non-secure server from scratch

Review Connection Warning showed
Certificate correctly displayed
Cancel -> auth process cancelled
Approve -> "Certificate Details" as "Accepted". Certificate added to Settings certificate place
Revoke Approval in Settings -> Have to be approved again -> changes that does not change (version, key size, key exponent)

Certificate changed after account was added

Certificate changes but key does not -> auto approved. Correct reason displayed in Settings -> Certificates
Key changes -> User warned. Diff displayed. Added to Settings -> Certificates

iPhoneXR v15.3
iPadAir v14.7

jesmrec · 2022-04-07T12:40:25Z

(1) [WONT FIX]

Just a comment, maybe not affecting.

Building the branch with Xcode 12.5 -> error Undefined symbol: PocketSVG_PocketSVG_SWIFTPM_MODULE_BUNDLE() . I wasn't able to build the branch under that error, with all dependencies up to date.

Building the branch with Xcode 13.2 -> works.

Since the idea is upgrading to latest SDK, it would be not relevant, right?

hosy · 2022-04-07T12:54:24Z

(1)

Just a comment, maybe not affecting.

Building the branch with Xcode 12.5 -> error Undefined symbol: PocketSVG_PocketSVG_SWIFTPM_MODULE_BUNDLE() . I wasn't able to build the branch under that error, with all dependencies up to date.

Building the branch with Xcode 13.2 -> works.

Since the idea is upgrading to latest SDK, it would be not relevant, right?

Yes, this is not a problem, because this branch will be build and shipped with Xcode 13.3. I think the problem is a new format of the package file. Not relevant, thank you for asking!

jesmrec · 2022-04-07T13:04:35Z

(2)

Not a regression -> not needed to be fixed here. Up to you.

Add a server (insecure) and accept certificate
Go to Settings and revoke certificate
Open list of files -> Certificate issue
Open Issue to check Certificate details

Current: some fields in the certificate do not seem to change but are marked as changes:

iPhoneXR v15.3
7a3bb76d

hosy · 2022-04-07T13:07:00Z

(2) should not be a blocker in this PR, but it could be added to the milestone PR and maybe @felix-schwarz can have a look. Thanks!

jesmrec · 2022-04-08T12:53:42Z

Checked the way certificates are shown in the app. It's OK from my side.

@hosy

* set up a new version 11.10.0 * [feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 (#1116) * - migrated code to new OpenSSL 1.1.1 API - using OpenSSL Package * - update SDK * - update ios-sdk Co-authored-by: Matthias Hühne <> Co-authored-by: Felix Schwarz <[email protected]> * #1114 If app is build as EMM version, the app shows an licensing error, when running shortcut intents (could not read app bundle identifier in extension) (#1122) Co-authored-by: Matthias Hühne <> * [feature/iOS-15-SDK] Build with iOS 15 SDK (#1121) * #1066 support for iOS 15 SDK: Solving UI issues, removing unneeded code * - updated Xcode version for fastlane - fastlane readme update Co-authored-by: Matthias Hühne <> * #1123 Account options were not dynamically provided for action "Delete Account Item", because of wrong intent configuration (#1125) Co-authored-by: Matthias Hühne <> * [fix/copy-timeout] Fix copy timeout (#1119) * - update SDK for improved error handling - add environment variable switch to enable/disable action-timeout-simulator host simulator * - update SDK with changes addressing code review findings by @hosy in #1119 * - added release notes changelog files - added in-app release notes - changed app version number - removed beta build warning * added OpenSSL changelog entry * updated Xcode version * only perform table updates, when query is final to prevent flickering and showing empty folder message (QA finding 1, 2) * moved changelog folder to new release folder * updated fastlane release notes for App Store * - change SDK reference from develop to release commit * fixed typo Co-authored-by: Matthias Hühne <> Co-authored-by: Felix Schwarz <[email protected]>

- migrated code to new OpenSSL 1.1.1 API

2a73908

- using OpenSSL Package

hosy added this to the 11.9.0-Current milestone Apr 5, 2022

hosy requested review from felix-schwarz and jesmrec April 5, 2022 13:20

hosy self-assigned this Apr 5, 2022

hosy changed the title ~~[feature/openssl-1.1.1]~~ [feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 Apr 6, 2022

hosy modified the milestones: 11.9.0-Current, 11.10.0-Current Apr 6, 2022

- update SDK

b8cb8b5

felix-schwarz changed the base branch from master to milestone/11.10.0 April 6, 2022 20:07

felix-schwarz approved these changes Apr 6, 2022

View reviewed changes

- update ios-sdk

7a3bb76

jesmrec approved these changes Apr 8, 2022

View reviewed changes

jesmrec added the Approved by QA Approved by QA label Apr 8, 2022

hosy merged commit 867c787 into milestone/11.10.0 Apr 8, 2022

delete-merged-branch bot deleted the feature/openssl-1.1.1 branch April 8, 2022 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 #1116

[feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 #1116

hosy commented Apr 5, 2022 •

edited by jesmrec

Loading

CLAassistant commented Apr 5, 2022 •

edited

Loading

jesmrec commented Apr 7, 2022 •

edited

Loading

jesmrec commented Apr 7, 2022 •

edited

Loading

hosy commented Apr 7, 2022

(1)

jesmrec commented Apr 7, 2022

hosy commented Apr 7, 2022

jesmrec commented Apr 8, 2022

[feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 #1116

[feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 #1116

Conversation

hosy commented Apr 5, 2022 • edited by jesmrec Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

QA

CLAassistant commented Apr 5, 2022 • edited Loading

jesmrec commented Apr 7, 2022 • edited Loading

jesmrec commented Apr 7, 2022 • edited Loading

(1) [WONT FIX]

hosy commented Apr 7, 2022

(1)

jesmrec commented Apr 7, 2022

(2)

hosy commented Apr 7, 2022

jesmrec commented Apr 8, 2022

hosy commented Apr 5, 2022 •

edited by jesmrec

Loading

CLAassistant commented Apr 5, 2022 •

edited

Loading

jesmrec commented Apr 7, 2022 •

edited

Loading

jesmrec commented Apr 7, 2022 •

edited

Loading