Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/copy-timeout] Fix copy timeout #1119

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

felix-schwarz
Copy link
Contributor

Description

  • increase HTTP request timeout for COPY actions from 1 minute to 10 minutes
  • improve error handling for request timeouts

Related Issue

Addresses https://github.com/owncloud/enterprise/issues/5008 .

Screenshots (if appropriate):

Simulator Screen Shot - iPhone 12 Pro Max - 2022-04-13 at 21 42 53

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- add environment variable switch to enable/disable action-timeout-simulator host simulator
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@felix-schwarz felix-schwarz added this to the 11.10.0-Current milestone Apr 13, 2022
@michaelstingl
Copy link
Contributor

I think 5 Minutes should be sufficient.

Copy link
Collaborator

@hosy hosy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you add all new and changed localised strings (in SDK) to to Localizable.strings file.

@felix-schwarz
Copy link
Contributor Author

Thanks. I added the missing strings.

@felix-schwarz felix-schwarz requested a review from hosy May 3, 2022 09:06
@jesmrec
Copy link
Contributor

jesmrec commented May 4, 2022

Checked with long copy operations, message at the bottom is gone when operation finishes.

Extra testing to do in regression stage.

@jesmrec jesmrec added the Approved by QA Approved by QA label May 4, 2022
@hosy hosy merged commit 94be438 into milestone/11.10.0 May 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/copy-timeout branch May 9, 2022 07:29
hosy added a commit that referenced this pull request May 17, 2022
* set up a new version 11.10.0

* [feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 (#1116)

* - migrated code to new OpenSSL 1.1.1 API
- using OpenSSL Package

* - update SDK

* - update ios-sdk

Co-authored-by: Matthias Hühne <>
Co-authored-by: Felix Schwarz <[email protected]>

* #1114 If app is build as EMM version, the app shows an licensing error, when running shortcut intents (could not read app bundle identifier in extension) (#1122)

Co-authored-by: Matthias Hühne <>

* [feature/iOS-15-SDK] Build with iOS 15 SDK (#1121)

* #1066 support for iOS 15 SDK: Solving UI issues, removing unneeded code

* - updated Xcode version for fastlane
- fastlane readme update

Co-authored-by: Matthias Hühne <>

* #1123 Account options were not dynamically provided for action "Delete Account Item", because of wrong intent configuration (#1125)

Co-authored-by: Matthias Hühne <>

* [fix/copy-timeout] Fix copy timeout (#1119)

* - update SDK for improved error handling
- add environment variable switch to enable/disable action-timeout-simulator host simulator

* - update SDK with changes addressing code review findings by @hosy in #1119

* - added release notes changelog files
- added in-app release notes
- changed app version number
- removed beta build warning

* added OpenSSL changelog entry

* updated Xcode version

* only perform table updates, when query is final to prevent flickering and showing empty folder message (QA finding 1, 2)

* moved changelog folder to new release folder

* updated fastlane release notes for App Store

* - change SDK reference from develop to release commit

* fixed typo

Co-authored-by: Matthias Hühne <>
Co-authored-by: Felix Schwarz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants