fix unmount item from share #8827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2403905
force-pushed
the
issue-8731
branch
3 times, most recently
from
88d7b7b
to
45ec0b8
Compare
2403905
force-pushed
the
issue-8731
branch
3 times, most recently
from
5f585b7
to
450a3fb
Compare
8 tasks
rhafer
requested changes
Apr 15, 2024
| WEB_COMMITID=5367936f30b07c0832fb8af09f9f7719cccf7038 | ||
| WEB_BRANCH=master | ||
| WEB_COMMITID=9b9616b8429432002d06c4a2c8f252cbe08fb735 | ||
| WEB_BRANCH=changeResponseCodeDelete |
There was a problem hiding this comment.
Should this really be part of the PR?
There was a problem hiding this comment.
Ok. This seems to be needed to resolve a circular dependency with web. Needs to be revert once the related web changes are merged.
| Bugfix: Fix unmount item from share | ||
|
|
||
| We fixed the issue when unmount item from share will result in 200 status code | ||
|
|
There was a problem hiding this comment.
We fixed the status code returned for the request to delete a driveitem.
|
rhafer
approved these changes
Apr 15, 2024
ownclouders
pushed a commit
that referenced
this pull request
Apr 15, 2024
fix unmount item from share
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fixed the issue when unmount item from share will result in 200 status code
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: