fix(rpc): less clones in logs filter (#7060)

Co-authored-by: Matthias Seitz <[email protected]>

Cargo.toml

@@ -188,7 +188,7 @@ reth-trie-parallel = { path = "crates/trie-parallel" }
 # revm
 revm = { version = "7.1.0", features = ["std", "secp256k1"], default-features = false }
 revm-primitives = { version = "3.0.0", features = ["std"], default-features = false }
-revm-inspectors = { git = "https://github.com/paradigmxyz/evm-inspectors", rev = "846dec1" }
+revm-inspectors = { git = "https://github.com/paradigmxyz/evm-inspectors", rev = "1f935e7" }
 
 # eth
 alloy-chains = { version = "0.1", feature = ["serde", "rlp", "arbitrary"] }
@@ -197,12 +197,12 @@ alloy-dyn-abi = "0.6"
 alloy-sol-types = "0.6"
 alloy-rlp = "0.3"
 alloy-trie = "0.3"
-alloy-rpc-types = { git = "https://github.com/alloy-rs/alloy", rev = "64d0352" }
-alloy-rpc-trace-types = { git = "https://github.com/alloy-rs/alloy", rev = "64d0352" }
-alloy-rpc-engine-types = { git = "https://github.com/alloy-rs/alloy", rev = "64d0352" }
-alloy-genesis = { git = "https://github.com/alloy-rs/alloy", rev = "64d0352" }
-alloy-node-bindings = { git = "https://github.com/alloy-rs/alloy", rev = "64d0352" }
-alloy-eips = { git = "https://github.com/alloy-rs/alloy", rev = "64d0352" }
+alloy-rpc-types = { git = "https://github.com/alloy-rs/alloy", rev = "9ac2c90" }
+alloy-rpc-trace-types = { git = "https://github.com/alloy-rs/alloy", rev = "9ac2c90" }
+alloy-rpc-engine-types = { git = "https://github.com/alloy-rs/alloy", rev = "9ac2c90" }
+alloy-genesis = { git = "https://github.com/alloy-rs/alloy", rev = "9ac2c90" }
+alloy-node-bindings = { git = "https://github.com/alloy-rs/alloy", rev = "9ac2c90" }
+alloy-eips = { git = "https://github.com/alloy-rs/alloy", rev = "9ac2c90" }
 
 # TODO: Remove
 ethers-core = { version = "2.0.14", default-features = false }
@@ -287,4 +287,4 @@ proptest = "1.4"
 proptest-derive = "0.4"
 serial_test = "3"
 similar-asserts = "1.5.0"
-test-fuzz = "5"
+test-fuzz = "5"

crates/rpc/rpc/src/eth/logs_utils.rs

@@ -3,7 +3,6 @@ use alloy_primitives::TxHash;
 use reth_primitives::{BlockNumHash, ChainInfo, Receipt, U256};
 use reth_provider::{BlockReader, ProviderError};
 use reth_rpc_types::{FilteredParams, Log};
-use reth_rpc_types_compat::log::from_primitive_log;
 
 /// Returns all matching of a block's receipts when the transaction hashes are known.
 pub(crate) fn matching_block_logs_with_tx_hashes<'a, I>(
@@ -119,8 +118,8 @@ pub(crate) fn log_matches_filter(
     if params.filter.is_some() &&
         (!params.filter_block_range(block.number) ||
             !params.filter_block_hash(block.hash) ||
-            !params.filter_address(&from_primitive_log(log.clone())) ||
-            !params.filter_topics(&from_primitive_log(log.clone())))
+            !params.filter_address(&log.address) ||
+            !params.filter_topics(&log.topics))
     {
         return false
     }

examples/db-access.rs

@@ -5,7 +5,6 @@ use reth_provider::{
     StateProvider, TransactionsProvider,
 };
 use reth_rpc_types::{Filter, FilteredParams};
-use reth_rpc_types_compat::log::from_primitive_log;
 use std::path::Path;
 
 // Providers are zero cost abstractions on top of an opened MDBX Transaction
@@ -201,8 +200,9 @@ fn receipts_provider_example<T: ReceiptProvider + TransactionsProvider + HeaderP
     {
         let receipts = provider.receipt(header_num)?.ok_or(eyre::eyre!("receipt not found"))?;
         for log in &receipts.logs {
-            let log = from_primitive_log(log.clone());
-            if filter_params.filter_address(&log) && filter_params.filter_topics(&log) {
+            if filter_params.filter_address(&log.address) &&
+                filter_params.filter_topics(&log.topics)
+            {
                 // Do something with the log e.g. decode it.
                 println!("Matching log found! {log:?}")
             }