Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): less clones in logs filter #7060

Merged
merged 6 commits into from
Mar 10, 2024
Merged

fix(rpc): less clones in logs filter #7060

merged 6 commits into from
Mar 10, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Mar 8, 2024 •
edited
Loading

Now possible with alloy-rs/alloy#257

@shekhirin shekhirin added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Mar 8, 2024
@shekhirin shekhirin marked this pull request as ready for review March 8, 2024 21:23
mattsse
mattsse approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make this nicer in the params type and get rid of the clone

@mattsse mattsse added this pull request to the merge queue Mar 9, 2024
@mattsse mattsse removed this pull request from the merge queue due to a manual request Mar 9, 2024
@mattsse
Copy link
Collaborator

mattsse commented Mar 9, 2024

ref alloy-rs/alloy#256

@mattsse mattsse mentioned this pull request Mar 9, 2024
Merged
@shekhirin shekhirin force-pushed the alexey/log-matches-filter-clone branch from 250fc1d to 7c1ee9a Compare March 10, 2024 13:19
@mattsse mattsse mentioned this pull request Mar 10, 2024
Merged
mattsse added a commit to paradigmxyz/revm-inspectors that referenced this pull request Mar 10, 2024
@mattsse
chore: bump alloy (#68)
1f935e7 
paradigmxyz/reth#7060
@mattsse mattsse enabled auto-merge March 10, 2024 14:10
@mattsse mattsse added this pull request to the merge queue Mar 10, 2024
Merged via the queue into main with commit 4943619 Mar 10, 2024
28 checks passed
@mattsse mattsse deleted the alexey/log-matches-filter-clone branch March 10, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst left review comments

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shekhirin @mattsse @gakonst @DaniPopes