Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for tx response verification #6926

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Add test for tx response verification #6926

merged 1 commit into from
Mar 2, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Mar 2, 2024

Adds a test for verification of a PooledTransactions response.

@emhane emhane requested a review from rkrasiuk March 2, 2024 00:14
@emhane emhane added C-test A change that impacts how or what we test A-networking Related to networking in general labels Mar 2, 2024
mattsse
mattsse approved these changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

rkrasiuk
rkrasiuk approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good, thank u

@rkrasiuk rkrasiuk added this pull request to the merge queue Mar 2, 2024
Merged via the queue into main with commit c82a84c Mar 2, 2024
29 checks passed
@rkrasiuk rkrasiuk deleted the emhane/test-verification-tx-response branch March 2, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emhane @mattsse @rkrasiuk