Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for tx response verification #6926

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Add test for tx response verification #6926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 41 additions & 3 deletions crates/net/network/src/transactions/fetcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ pub struct UnverifiedPooledTransactions {
}

/// [`PooledTransactions`] that have been successfully verified.
#[derive(Debug, Constructor)]
#[derive(Debug, Constructor, Deref)]
pub struct VerifiedPooledTransactions {
txns: PooledTransactions,
}
Expand Down Expand Up @@ -1188,10 +1188,11 @@ impl Default for TransactionFetcherInfo {

#[cfg(test)]
mod test {
use std::collections::HashSet;
use std::{collections::HashSet, str::FromStr};

use alloy_rlp::Decodable;
use derive_more::IntoIterator;
use reth_primitives::B256;
use reth_primitives::{hex, TransactionSigned, B256};

use crate::transactions::tests::{default_cache, new_mock_session};

Expand Down Expand Up @@ -1364,4 +1365,41 @@ mod test {
seen_hashes.into_iter().collect::<HashSet<_>>()
)
}

#[test]
fn verify_response_hashes() {
let input = hex!("02f871018302a90f808504890aef60826b6c94ddf4c5025d1a5742cf12f74eec246d4432c295e487e09c3bbcc12b2b80c080a0f21a4eacd0bf8fea9c5105c543be5a1d8c796516875710fafafdf16d16d8ee23a001280915021bb446d1973501a67f93d2b38894a514b976e7b46dc2fe54598daa");
let signed_tx_1: PooledTransactionsElement =
TransactionSigned::decode(&mut &input[..]).unwrap().into();
let input = hex!("02f871018302a90f808504890aef60826b6c94ddf4c5025d1a5742cf12f74eec246d4432c295e487e09c3bbcc12b2b80c080a0f21a4eacd0bf8fea9c5105c543be5a1d8c796516875710fafafdf16d16d8ee23a001280915021bb446d1973501a67f93d2b38894a514b976e7b46dc2fe54598d76");
let signed_tx_2: PooledTransactionsElement =
TransactionSigned::decode(&mut &input[..]).unwrap().into();

// only tx 1 is requested
let request_hashes = [
B256::from_str("0x3b9aca00f0671c9a2a1b817a0a78d3fe0c0f776cccb2a8c3c1b412a4f4e67890")
.unwrap(),
*signed_tx_1.hash(),
B256::from_str("0x3b9aca00f0671c9a2a1b817a0a78d3fe0c0f776cccb2a8c3c1b412a4f4e12345")
.unwrap(),
B256::from_str("0x3b9aca00f0671c9a2a1b817a0a78d3fe0c0f776cccb2a8c3c1b412a4f4edabe3")
.unwrap(),
];

for hash in &request_hashes {
assert_ne!(hash, signed_tx_2.hash())
}

let request_hashes = RequestTxHashes::new(request_hashes.clone().to_vec());

// but response contains tx 1 + another tx
let response_txns = PooledTransactions(vec![signed_tx_1.clone(), signed_tx_2.clone()]);
let payload = UnverifiedPooledTransactions::new(response_txns);

let (outcome, verified_payload) = payload.verify(&request_hashes, &PeerId::ZERO);

assert_eq!(VerificationOutcome::ReportPeer, outcome);
assert_eq!(1, verified_payload.len());
assert!(verified_payload.contains(&signed_tx_1));
}
}
Loading