found potential root cause and fix for deadlocks and random crashes i…

…n benchmarks (ycsb, gavel, tpcc, tpch, etc.),

core/src/main/java/org/polypheny/db/functions/Functions.java

@@ -2137,7 +2137,7 @@ public static PolyBoolean isNotFalse( PolyBoolean b ) {
      * NULL → NULL, FALSE → TRUE, TRUE → FALSE.
      */
     public static PolyBoolean not( PolyBoolean b ) {
-        return PolyBoolean.of( !b.value );
+        return b == null ? PolyBoolean.of( null ): PolyBoolean.of( !b.value );
     }
 
 

core/src/main/java/org/polypheny/db/languages/LanguageManager.java

@@ -195,6 +195,10 @@ public List<ImplementationContext> anyPrepareQuery( QueryContext context, Statem
                     if ( transaction.isAnalyze() ) {
                         statement.getOverviewDuration().stop( "Translation" );
                     }
+
+                    if ( !statement.getTransaction().isActive() ) {
+                        log.warn( "Transaction is not active" );
+                    }
                     implementation = statement.getQueryProcessor().prepareQuery( root, true );
                 }
                 // queries are able to switch the context of the following queries

dbms/src/main/java/org/polypheny/db/transaction/LockManager.java

@@ -38,7 +38,7 @@ public class LockManager {
     public static final LockManager INSTANCE = new LockManager();
 
     private boolean isExclusive = false;
-    private final Set<Xid> owners = new HashSet<>();
+    private final Set<Long> owners = new HashSet<>();
     private final ConcurrentLinkedQueue<Thread> waiters = new ConcurrentLinkedQueue<>();
     private final ReentrantLock lock = new ReentrantLock();
     private final Condition condition = lock.newCondition();
@@ -54,7 +54,7 @@ public void lock( LockMode mode, @NonNull Transaction transaction ) throws Deadl
             if ( owners.isEmpty() ) {
                 handleLockOrThrow( mode, transaction );
                 return;
-            } else if ( owners.contains( transaction.getXid() ) && (mode == LockMode.SHARED || isExclusive) ) {
+            } else if ( owners.contains( transaction.getId() ) && (mode == LockMode.SHARED || isExclusive) ) {
                 log.debug( "already locked {}", transaction.getXid() );
                 // already have the required lock
                 return;
@@ -69,7 +69,7 @@ public void lock( LockMode mode, @NonNull Transaction transaction ) throws Deadl
             lock.lock();
             try {
                 while ( waiters.peek() != thread ) {
-                    log.debug( "wait {} ", transaction.getXid() );
+                    log.debug( "wait {} ", transaction.getId() );
                     boolean successful = condition.await( RuntimeConfig.LOCKING_MAX_TIMEOUT_SECONDS.getInteger(), TimeUnit.SECONDS );
                     if ( !successful ) {
                         cleanup( thread );
@@ -120,23 +120,23 @@ private void handleLockOrThrow( LockMode mode, @NotNull Transaction transaction
     private synchronized boolean handleSimpleLock( @NonNull LockMode mode, Transaction transaction ) {
         if ( mode == LockMode.EXCLUSIVE ) {
             // get w
-            if ( owners.isEmpty() || (owners.size() == 1 && owners.contains( transaction.getXid() )) ) {
+            if ( owners.isEmpty() || (owners.size() == 1 && owners.contains( transaction.getId() )) ) {
                 if ( isExclusive ) {
                     log.debug( "lock already exclusive" );
                     return true;
                 }
 
                 log.debug( "x lock {}", transaction.getXid() );
                 isExclusive = true;
-                owners.add( transaction.getXid() );
+                owners.add( transaction.getId() );
                 return true;
             }
 
         } else {
             // get r
-            if ( !isExclusive || owners.contains( transaction.getXid() ) ) {
+            if ( !isExclusive || owners.contains( transaction.getId() ) ) {
                 log.debug( "r lock {}", transaction.getXid() );
-                owners.add( transaction.getXid() );
+                owners.add( transaction.getId() );
                 return true;
             }
 
@@ -158,7 +158,7 @@ private void signalAll() {
 
 
     public synchronized void unlock( @NonNull Transaction transaction ) {
-        if ( !owners.contains( transaction.getXid() ) ) {
+        if ( !owners.contains( transaction.getId() ) ) {
             log.debug( "Transaction is no owner" );
             return;
         }
@@ -167,7 +167,7 @@ public synchronized void unlock( @NonNull Transaction transaction ) {
             isExclusive = false;
         }
         log.debug( "release {}", transaction.getXid() );
-        owners.remove( transaction.getXid() );
+        owners.remove( transaction.getId() );
 
         // wake up waiters
         signalAll();

dbms/src/main/java/org/polypheny/db/transaction/TransactionImpl.java

@@ -199,6 +199,9 @@ public void commit() throws TransactionException {
             for ( Adapter<?> adapter : involvedAdapters ) {
                 adapter.commit( xid );
             }
+            if ( involvedAdapters.isEmpty() ) {
+                log.debug( "No adapter used." );
+            }
 
             this.statements.forEach( statement -> {
                 if ( statement.getMonitoringEvent() != null ) {

plugins/jdbc-adapter-framework/src/main/java/org/polypheny/db/adapter/jdbc/ResultSetEnumerable.java

@@ -411,7 +411,7 @@ private Enumerator<PolyValue[]> enumeratorBasedOnStatement() {
                 int updateCount = statement.getUpdateCount();
                 return Linq4j.singletonEnumerator( new PolyValue[]{ PolyLong.of( updateCount ) } );
             }
-        } catch ( SQLException e ) {
+        } catch ( Throwable e ) {
             throw Static.RESOURCE.exceptionWhilePerformingQueryOnJdbcSubSchema( sql ).ex( e );
         } finally {
             closeIfPossible( statement );
@@ -439,7 +439,7 @@ private Enumerator<PolyValue[]> enumeratorBasedOnPreparedStatement() {
                     return Linq4j.singletonEnumerator( new PolyValue[]{ PolyLong.of( updateCount ) } );
                 }
             }
-        } catch ( SQLException e ) {
+        } catch ( Throwable e ) {
             throw Static.RESOURCE.exceptionWhilePerformingQueryOnJdbcSubSchema( sql ).ex( e );
         } finally {
             closeIfPossible( preparedStatement );

plugins/jdbc-adapter-framework/src/main/java/org/polypheny/db/adapter/jdbc/stores/AbstractJdbcStore.java

@@ -466,7 +466,7 @@ public void commit( PolyXid xid ) {
         if ( connectionFactory.hasConnectionHandler( xid ) ) {
             try {
                 connectionFactory.getConnectionHandler( xid ).commit();
-            } catch ( ConnectionHandlerException e ) {
+            } catch ( Throwable e ) {
                 throw new GenericRuntimeException( e );
             }
         } else {

plugins/prism-interface/src/main/java/org/polypheny/db/prisminterface/PIClient.java

@@ -32,6 +32,8 @@ public class PIClient {
     @Getter
     private final String clientUUID;
     private final LogicalUser catalogUser;
+    @Getter
+    @Setter
     private Transaction currentTransaction;
     private final TransactionManager transactionManager;
     @Getter
@@ -94,7 +96,7 @@ private void commitCurrentTransactionUnsynchronized() throws PIServiceException
         }
         try {
             currentTransaction.commit();
-        } catch ( TransactionException e ) {
+        } catch ( Throwable e ) {
             throw new PIServiceException( "Committing current transaction failed: " + e.getMessage() );
         } finally {
             clearCurrentTransaction();

plugins/prism-interface/src/main/java/org/polypheny/db/prisminterface/PIService.java

@@ -429,6 +429,12 @@ private Response prepareIndexedStatement( PrepareStatementRequest request, Respo
     private Response executeIndexedStatement( ExecuteIndexedStatementRequest request, ResponseMaker<StatementResult> responseObserver ) {
         PIClient client = getClient();
         PIPreparedIndexedStatement statement = client.getStatementManager().getIndexedPreparedStatement( request.getStatementId() );
+        if ( statement != null && statement.getTransaction() != null && client.getCurrentTransaction() != null && statement.getTransaction().getId() != client.getCurrentTransaction().getId() ) {
+            if ( !statement.getTransaction().isActive() ){ // todo @gartens @tobiashafner fix
+                log.debug( "This definitely should not happen! {}", statement.getTransaction().getId() );
+                statement.setStatement( client.getCurrentTransaction().createStatement() );
+            }
+        }
         int fetchSize = request.hasFetchSize()
                 ? request.getFetchSize()
                 : PropertyUtils.DEFAULT_FETCH_SIZE;

plugins/prism-interface/src/main/java/org/polypheny/db/prisminterface/statements/PIPreparedIndexedStatement.java

@@ -39,6 +39,7 @@
 public class PIPreparedIndexedStatement extends PIPreparedStatement {
 
     private final String query;
+    @Setter
     private Statement statement;
     @Setter
     private PolyImplementation implementation;
@@ -173,7 +174,7 @@ public void close() {
 
     @Override
     public Transaction getTransaction() {
-        return statement.getTransaction();
+        return statement != null ? statement.getTransaction() : null;
     }
 
 }