[Fix] Double rollback calls in transactions (#222)

powersync-ja · Jul 11, 2024 · 8d5b702 · 8d5b702
1 parent f60fbed
commit 8d5b702
Show file tree

Hide file tree

Showing 5 changed files with 17,266 additions and 22,013 deletions.
diff --git a/.changeset/new-melons-sell.md b/.changeset/new-melons-sell.md
@@ -0,0 +1,5 @@
+---
+'@powersync/web': patch
+---
+
+Silencing transactions that are reporting on failed rollback exceptions when they are safe to ignore.
diff --git a/.changeset/red-jobs-turn.md b/.changeset/red-jobs-turn.md
@@ -0,0 +1,5 @@
+---
+'@powersync/react-native': patch
+---
+
+Updated dependencies
diff --git a/packages/react-native/package.json b/packages/react-native/package.json
@@ -27,7 +27,7 @@
   },
   "homepage": "https://docs.powersync.com/",
   "peerDependencies": {
-    "@journeyapps/react-native-quick-sqlite": "^1.1.6",
+    "@journeyapps/react-native-quick-sqlite": "^1.1.8",
     "react": "*",
     "react-native": "*",
     "react-native-polyfill-globals": "^3.1.0",
@@ -41,7 +41,7 @@
     "react-native-fetch-api": "^3.0.0"
   },
   "devDependencies": {
-    "@journeyapps/react-native-quick-sqlite": "^1.1.6",
+    "@journeyapps/react-native-quick-sqlite": "^1.1.8",
     "@types/async-lock": "^1.4.0",
     "react": "18.2.0",
     "react-native": "0.72.4",

diff --git a/packages/web/src/db/adapters/wa-sqlite/WASQLiteDBAdapter.ts b/packages/web/src/db/adapters/wa-sqlite/WASQLiteDBAdapter.ts
@@ -199,7 +199,12 @@ export class WASQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
         return result;
       } catch (ex) {
         this.logger.debug('Caught ex in transaction', ex);
-        await rollback();
+        try {
+          await rollback();
+        } catch (ex2) {
+          // In rare cases, a rollback may fail.
+          // Safe to ignore.
+        }
         throw ex;
       }
     };