MgidX Bid Adapter : initial release #10015
Conversation
Get last Prebid.js changes
new adapter - MgidX
|
Hi, @Fawke. I see that circleci build is failed, but I can`t open details, I have a loading screen that won't finish. Is this ok? |
|
@ChrisHuie Can you please help with the failing Circle Ci check? I ran the command multiple times but it's giving me some error here It doesn't seem to be failing because of this PR, but the check is passing for other PRs currently open. Do we need to make another empty commit to make this pass? I remember you did something similar in the past to fix this. |
|
@Fawke oh, sorry, docs PR is here - prebid/prebid.github.io#4610 |
| host, | ||
| page, | ||
| placements, | ||
| coppa: config.getConfig('coppa') === true ? 1 : 0, |
There was a problem hiding this comment.
please prefer bidder request object
| query.push(`us_privacy=${encodeURIComponent(uspConsent?.consentString)}`); | ||
| } | ||
| if (isPlainObject(gppConsent) && gppConsent?.gppString) { | ||
| query.push(`gppString=${encodeURIComponent(gppConsent?.gppString)}`); |
There was a problem hiding this comment.
sorry, didn't notice that. now we don't need sid and gppString params
|
@xmgiddev pulling in commits currently on master should fix testing issue :) |
Co-authored-by: Evgeny Nagorny <[email protected]> Co-authored-by: xmgiddev <>
Co-authored-by: Evgeny Nagorny <[email protected]> Co-authored-by: xmgiddev <>
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information