Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apester prebid js adapter doc #4629

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

apykhteyev
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

prebid/Prebid.js#10057

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit bc44aa8
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/64a26decdfc4e100083f1416
😎 Deploy Preview https://deploy-preview-4629--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

media_types: video, banner
userIds: all
fpd_supported: false
gdpr_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no gvl_id and I couldn't find any consent handling in your adapter. How do you support GDPR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated docs, thanks


Apester client-side Prebid.js adapter requires only `host`, `adUnitId`, `adUnitType`.

Apester client-side Prebid.js adapter supports only `banner` and `video` media types, doesn't support `audio` and `native`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be covered by the media_types meta data in the header, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated doc, thanks

@bretg
Copy link
Contributor

bretg commented Jun 29, 2023

@apykhteyev - please take a look at @muuki88 's items above.

@bretg bretg requested a review from muuki88 July 5, 2023 15:12
@muuki88 muuki88 added LGTM and removed needs work labels Jul 6, 2023
@muuki88 muuki88 merged commit 59284d8 into prebid:master Jul 6, 2023
5 checks passed
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* Add Apester prebid js adapter doc

* fix

* Fix comments

---------

Co-authored-by: apykhteyev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants