Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT [Weborama RTD Submodule] Fix appnexus implementation #10113

Closed
wants to merge 10 commits into from

Conversation

peczenyj
Copy link
Contributor

Type of change

  • Bugfix
  • Refactoring (no functional changes, no api changes)

Description of change

This Pull Requests finish the work started on #10005

Here we:

  1. send data to AppNexus using site.content.keywords or user.keywords using the format key=foo,key=bar,...
  2. remove the hard coded bidder name appnexus to use it as a default value. Other aliases can be added via configuration
  3. check the bidder alias registry based on configuration

Today we check for appnexus and registered aliases and we don't want to remove this behavior without warn all of our customers. We plan some modifications to do in the next releases to avoid break backward compatibility.

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 19, 2023

The way you have this set up is a rules violation; please inspect 1plusX and Airgrid. I registered a segment taxonomy with the IAB on your behalf. If you write to segments, appnexus can pick them up now in 8.0 Thanks!

@peczenyj
Copy link
Contributor Author

The way you have this set up is a rules violation; please inspect 1plusX and Airgrid. I registered a segment taxonomy with the IAB on your behalf. If you write to segments, appnexus can pick them up now in 8.0 Thanks!

Sorry, I am a little bit lost: what is the rule violation that I am doing here?
I am following what sirdata is doing right now.

Perhaps I lost something from the comments on the previous MR #10005

@peczenyj
Copy link
Contributor Author

BTW if the correct development is just remove any code that handles bib.bidder === 'appnexus' I can provide it ASAP

@patmmccann
Copy link
Collaborator

Yes, please don't reference bid adapters in the module. However, feel free to append to this so appnexus picks up your segments

const ORTB_SEGTAX_KEY_MAP = {

@patmmccann
Copy link
Collaborator

@peczenyj is this ready?

Our goal here isn't to break your integration with any bidder, it's to move the handling so publisher data controls are not bypassed when publishers attempt to suppress parts of the bids request object using data or activity control features.

Are you satisfied this achieves that goal? If not, we're committed to assist

@peczenyj
Copy link
Contributor Author

@peczenyj is this ready?

Our goal here isn't to break your integration with any bidder, it's to move the handling so publisher data controls are not bypassed when publishers attempt to suppress parts of the bids request object using data or activity control features.

Are you satisfied this achieves that goal? If not, we're committed to assist

To be honest, this is ready if Appnexus is ready to use the ortb2Fragment. I think it is not the case, based on the previous merge request #10005

@peczenyj peczenyj changed the title [Weborama RTD Submodule] Fix appnexus implementation DRAFT [Weborama RTD Submodule] Fix appnexus implementation Jun 22, 2023
@peczenyj peczenyj marked this pull request as draft June 30, 2023 13:41
@patmmccann
Copy link
Collaborator

@dgirardi @jsnellbaker any thoughts on how to push forward here? we'd love to restore all functionality

@peczenyj peczenyj marked this pull request as ready for review September 14, 2023 15:30
@peczenyj
Copy link
Contributor Author

hello @patmmccann @dgirardi and @jsnellbaker

I was revisiting this subject, but after a long time I must rewind it to the begining and start again.

It seems the options for weborama here are:

  1. use an IAB Taxonomy and register it on appnexus library to be collected and merged with their own data (and it depends on we start to work with such taxonomy and appnexus accept our vendor id in their library to be released at some point).
  2. since appnexus supports ortb2.ext.data.keywords we can try to adapt our data to expose it as keywords (however this will be available to all bidders, so we will duplicate our data).
  3. remove the specific code to appnexus -- and drop support to it

It seems the options for appnexus here are:

  1. Do Nothing
  2. start to handle ortb2.site.ext.data and/or ortb2.user.ext.data like many other bidders

From our side we start to talk about the possible solutions 1 and/or 2.

Regards

@patmmccann
Copy link
Collaborator

Option 1 seems quite workable, and has been accomplished by others. Why not persue that?

@patmmccann patmmccann self-assigned this Dec 20, 2023
@patmmccann
Copy link
Collaborator

closing as stale, feel free to resubmit

@patmmccann patmmccann closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants