weborama rtd submodule update doc to reflect fix in appnexus integration for v8 #4655
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@peczenyj - please fix merge conflicts. Thanks. |
peczenyj
changed the title
done |
There was a problem hiding this comment.
@peczenyj - thanks for the update. Looking over this doc from a publisher's perspective, I'd like to know if there's a big difference from how you configure this module in 7.x vs 8.x. If so, I think the parameter tables and the example section needs to more clear about the differences.
You've listed several params as "deprecated", which is good, but I think that might need to be clearer since many publishers will continue to use 7.x for quite a while. i.e. please consider updating the wording so it says "use this in 7.x" or "use this in 8.x".
Hello I think we will omit some details for a while. There is still a debate about what will be really deprecate on this module thanks |
There was a problem hiding this comment.
Ok - thanks. Next issue -- formatting. Take a look at the preview of your page at https://deploy-preview-4655--prebid-docs-preview.netlify.app/dev-docs/modules/weboramartdprovider
Your tables are missing this line:
{: .table .table-bordered .table-striped }
Please add this just before each table.
…ion for v8 (prebid#4655) * update doc to reflect fix in appnexus integration for v8 * simplify docs * add format to tables
🏷 Type of documentation
📋 Checklist
This PR depends on this intermediate development - already released on v7.53.0 :
#4647