Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preciso Bid adapter : Initial release #10138

Merged
merged 19 commits into from
Aug 23, 2023
Merged

Conversation

PrecisoSRL
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@PrecisoSRL
Copy link
Contributor Author

doc : prebid/prebid.github.io#4639

modules/precisoBidAdapter.js Outdated Show resolved Hide resolved
modules/precisoBidAdapter.js Outdated Show resolved Hide resolved
modules/precisoBidAdapter.js Outdated Show resolved Hide resolved
modules/precisoBidAdapter.md Outdated Show resolved Hide resolved
modules/precisoBidAdapter.js Outdated Show resolved Hide resolved
@ncolletti
Copy link
Contributor

We would expect to see your endpoint return bids when testing using the local environment within the prebid.js repo. After the recent updates and using the parameters in your markdown file, I am currently I'm seeing CORS errors on your AD_URL endpoint

@ncolletti
Copy link
Contributor

Checked back in, I am still seeing a CORS error from your endpoint when testing with the supplied params and endpoint from this PR. Could you please look into updating your server so it returns a valid bid to complete my testing? Thank you

@PrecisoSRL
Copy link
Contributor Author

Thank you for updating me. Currently, we are working on fixing the issue. As soon as it is completed, we will update here.

@PrecisoSRL
Copy link
Contributor Author

On the particular server, we deployed our bidder application. Would you mind testing again?

@ncolletti
Copy link
Contributor

@PrecisoSRL Looks like there is still a CORS error. To test on your end, you can run a gulp serve and then navigate to http://localhost:9999/integrationExamples/gpt/hello_world.html and enter your bidder params from your markdown file.

@PrecisoSRL
Copy link
Contributor Author

thank you for updating me. we will check and fix the issue as soon as possible

@ncolletti
Copy link
Contributor

@PrecisoSRL Seeing a 204 now, which is good progress. Now can you make sure your example params in your markdown file return test responses for these specific params? The expectation is that a User can try out your adapter and see it working in the their Prebid auction. We'd like to see this before we can move forward with approving the PR. Thank you!

integrationExamples/gpt/hello_world.html Outdated Show resolved Hide resolved
Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ncolletti ncolletti merged commit 59338f3 into prebid:master Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants