Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Bidder Doc: Preciso bidder doc added #4639

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

PrecisoSRL
Copy link
Contributor

@PrecisoSRL PrecisoSRL commented Jun 14, 2023

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit ca0d482
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6493ed1f4278a90008f66cff
😎 Deploy Preview https://deploy-preview-4639--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PrecisoSRL PrecisoSRL requested a review from muuki88 June 16, 2023 06:04
@muuki88 muuki88 added the LGTM label Jun 16, 2023
@bretg
Copy link
Contributor

bretg commented Jul 7, 2023

The PBS-Java adapter is done. Waiting on PBJS. If you want to get this doc out immediately, you can flip pbjs: false and we can merge, then once PBJS is merged, you can change it back to true

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few formatting things. We still need to wait for prebid.js being merged

gdpr_supported: true
gvl_id: 874
media_types: display, video, native
gdpr_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gdpr_supported: true
tcfeu_supported: true

Comment on lines +37 to +38
### ORTB Blocking
Preciso supports blocking advertisers in `badv` and categories in `bcat` parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### ORTB Blocking
Preciso supports blocking advertisers in `badv` and categories in `bcat` parameters.
### ORTB Blocking
Preciso supports blocking advertisers in `badv` and categories in `bcat` parameters.

Comment on lines +43 to +45
For example:
#### Globally defined ORTB Blocking:
```javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For example:
#### Globally defined ORTB Blocking:
```javascript
For example:
#### Globally defined ORTB Blocking
```javascript

Comment on lines +51 to +56
)};
```
#### ORTB Blocking specific only to preciso bidder:
```javascript
pbjs.setBidderConfig({
bidders: ['preciso'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)};
```
#### ORTB Blocking specific only to preciso bidder:
```javascript
pbjs.setBidderConfig({
bidders: ['preciso'],
)};

ORTB Blocking specific only to preciso bidder

pbjs.setBidderConfig({
  bidders: ['preciso'],

@muuki88 muuki88 merged commit 46d71bf into prebid:master Aug 24, 2023
5 checks passed
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* bidder Doc: Preciso bidder doc added

* added multiformat_support

* Changed pbjs as true

* corrections on ORTB blocking

---------

Co-authored-by: Nikhil Gopal Chennissery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants