Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttd Bid Adapter: use bidderRequestId instead of auctionId #10411

Merged
merged 1 commit into from
Aug 31, 2023
Merged

ttd Bid Adapter: use bidderRequestId instead of auctionId #10411

merged 1 commit into from
Aug 31, 2023

Conversation

khang-vu-ttd
Copy link
Contributor

Type of change

  • Bugfix

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
    No

Description of change

Notice that ttd adapter is using bidderRequest.auctionId instead of bidderRequest.bidderRequestId.

Looking at df66cdb it seems like it should be bidderRequest.bidderRequestId

Other information

@khang-vu-ttd
Copy link
Contributor Author

khang-vu-ttd commented Aug 29, 2023 •
edited
Loading

Just to confirm
bidderRequest.bidderRequestId will never be null?

unlike auctionid/transactionid (bidderRequest.ortb2.source.tid/ortbImp.ext.tid) which are controlled by the pbjs.setConfig({enableTIDs: true}) flag

@khang-vu-ttd khang-vu-ttd changed the title ttd Bid Adapter: use bidderRequestId instead of auctionid ttd Bid Adapter: use bidderRequestId instead of auctionId Aug 30, 2023
@patmmccann
Copy link
Collaborator

That's correct, not sure how I missed this, good catch

@patmmccann patmmccann merged commit f6e4796 into prebid:master Aug 31, 2023
4 checks passed
@patmmccann patmmccann self-assigned this Aug 31, 2023
@khang-vu-ttd khang-vu-ttd deleted the kvu-OPATH-1131-dont-use-transactionid-for-bidid branch August 31, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khang-vu-ttd @patmmccann