Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttd Bid Adapter: use bidderRequestId instead of auctionId #10411

Merged
merged 1 commit into from
Aug 31, 2023
Merged

ttd Bid Adapter: use bidderRequestId instead of auctionId #10411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/ttdBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, VIDEO } from '../src/mediaTypes.js';
import {isNumber} from '../src/utils.js';

const BIDADAPTERVERSION = 'TTD-PREBID-2022.06.28';
const BIDADAPTERVERSION = 'TTD-PREBID-2023.09.05';
const BIDDER_CODE = 'ttd';
const BIDDER_CODE_LONG = 'thetradedesk';
const BIDDER_ENDPOINT = 'https://direct.adsrvr.org/bid/bidder/';
Expand Down Expand Up @@ -406,7 +406,7 @@ export const spec = {
buildRequests: function (validBidRequests, bidderRequest) {
const firstPartyData = bidderRequest.ortb2 || {};
let topLevel = {
id: bidderRequest.auctionId,
id: bidderRequest.bidderRequestId,
imp: validBidRequests.map(bidRequest => getImpression(bidRequest)),
site: getSite(bidderRequest, firstPartyData),
device: getDevice(firstPartyData),
Expand Down
5 changes: 5 additions & 0 deletions test/spec/modules/ttdBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ describe('ttdBidAdapter', function () {
expect(request.data).to.be.not.null;
});

it('sets bidrequest.id to bidderRequestId', function () {
const requestBody = testBuildRequests(baseBannerBidRequests, baseBidderRequest).data;
expect(requestBody.id).to.equal('18084284054531');
});

it('sets impression id to ad unit\'s bid id', function () {
const requestBody = testBuildRequests(baseBannerBidRequests, baseBidderRequest).data;
expect(requestBody.imp[0].id).to.equal('243310435309b5');
Expand Down