Conversant Bid Adapter: handle paapi data in the response #11663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Jun 3, 2024
patmmccann
reviewed
Jun 3, 2024
modules/conversantBidAdapter.js
Outdated
| @@ -176,7 +176,18 @@ export const spec = { | |||
| * @return {Bid[]} An array of bids which were nested inside the server. | |||
| */ | |||
| interpretResponse: function(serverResponse, bidRequest) { | |||
| return converter.fromORTB({request: bidRequest.data, response: serverResponse.body}); | |||
| const ortbBids = converter.fromORTB({request: bidRequest.data, response: serverResponse.body}); | |||
| const ortbAuctionConfigs = deepAccess(serverResponse, 'body.ext.igi') || []; | |||
There was a problem hiding this comment.
is this not handled here now?
0ee4efd#diff-24ee01f9467dc2a1704da10ca938150df2b3386d6b5b732870760dbc7cd1c4d7R373
cc @dgirardi
There was a problem hiding this comment.
looks like as of today it is. I'll go back through my changes and check it out
There was a problem hiding this comment.
yes - this is no longer necessary. note that if you decide to keep it, paapiAuctionConfigs was renamed to just paapi (since it can also contain igs now) .
patmmccann
requested changes
Jun 3, 2024
johnwier
force-pushed
the
cnvr_paapiSupport
branch
from
afb846c
to
9945b9a
Compare
johnwier
force-pushed
the
cnvr_paapiSupport
branch
from
9945b9a
to
7c06ec6
Compare
patmmccann
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
[X ] Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Conversant bid adapter: Add support for handling paapi data in bid response
Other information