Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UNICORN bid adapter #4917

Merged
merged 5 commits into from
Mar 12, 2020
Merged

add UNICORN bid adapter #4917

merged 5 commits into from
Mar 12, 2020

Conversation

ctylim
Copy link
Contributor

@ctylim ctylim commented Mar 2, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'unicorn',
  params: {
    placementId: 'rectangle-ad-1',
    bidfloorCpm: 0.2,
    accountId: 12345,
    bcat: ['IAB-1', 'IAB-2']
  }
}

@harpere harpere requested a review from musikele March 5, 2020 18:17
musikele
musikele suggested changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for some problems that must be fixed before the bidder is merged. Please adjust the code accordingly.

modules/unicornBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/unicornBidAdapter_spec.js Outdated Show resolved Hide resolved
modules/unicornBidAdapter.js Outdated Show resolved Hide resolved
@ctylim
Copy link
Contributor Author

ctylim commented Mar 11, 2020

Hi @musikele,
Thank you for your review, fixed some errors.

@ctylim ctylim requested a review from musikele March 11, 2020 07:28
@musikele
Copy link
Contributor

@ctylim the PR looks good to me
you only need to rebase this to latest master commit, because prebid.js introduced a series of new checks and test fixes on CI. Once you do this, I'll merge.
If you need any help let me know
Thank you !

@ctylim
Copy link
Contributor Author

ctylim commented Mar 11, 2020

@musikele I'm done!

musikele
musikele approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musikele musikele merged commit f890eb8 into prebid:master Mar 12, 2020
@ctylim ctylim deleted the unicorn branch March 12, 2020 09:25
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
36fab76 
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
@redaguermas
Merge branch 'master' into NoBid-Version-1.2.4
031ebf1 
* master: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
@ctylim
add UNICORN bid adapter (prebid#4917)
0843f6c 
* add UNICORN bid adapter

* fix not using flatMap

* fix symbol error

* care lint & empty response

* care lint & add tests
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
@ctylim @rjvelicaria
add UNICORN bid adapter (prebid#4917)
d1d144f 
* add UNICORN bid adapter

* fix not using flatMap

* fix symbol error

* care lint & empty response

* care lint & add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musikele musikele musikele approved these changes

Assignees

@musikele musikele

Labels
needs docs needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctylim @musikele @harpere