Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mediaforce bid adapter #4933

Merged
merged 2 commits into from
Mar 11, 2020
Merged

add mediaforce bid adapter #4933

merged 2 commits into from
Mar 11, 2020

Conversation

ksanksana
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Add mediaforce Bid Adapter

  • test parameters for validating bids
{
  bidder: 'mediaforce',
  params: {
    placement_id: 13144370,
    publisher_id: 'pub111'
  }
}

@harpere harpere requested a review from Fawke March 5, 2020 22:16
Fawke
Fawke requested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksanksana,
Thanks for the PR.

I tried testing your example, the one you gave in the md file, with the hello_world page. It's returning 204 No Content

Here's a screenshot for your reference.
Screenshot 2020-03-06 at 4 20 08 PM

@ksanksana
Copy link
Contributor Author

Hi @Fawke ,
Sorry for that! Please try again now. You may need several attempts to get a real bid.

Fawke
Fawke reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fawke ,
Sorry for that! Please try again now. You may need several attempts to get a real bid.

Hi @ksanksana, I tried several times and I finally got a bid response. Is there any particular reason for this behaviour?

test/spec/modules/mediaforceBidAdapter_spec.js
return navigator[language].split('-')[0];
}

const language = getLanguage();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this variable being used anywhere else in the code. Do we need it?

@ksanksana
Copy link
Contributor Author

ksanksana commented Mar 10, 2020 •
edited
Loading

Hi @Fawke,

I don't see this variable being used anywhere else in the code. Do we need it?

I added the use of a previously unused variable "language".

I tried several times and I finally got a bid response. Is there any particular reason for this behaviour?

This is our production url, which has some heuristics underneath, which decides whether to yes-bid or no - depending on whether request is valuable for ur or not. We had made it yes-bid more often for the test period (so it did), but making it yes-bid all the time is an additional effort (not required for production), so we try to avoid it.

@Fawke
Copy link
Contributor

Fawke commented Mar 11, 2020

Hi @Fawke,

I don't see this variable being used anywhere else in the code. Do we need it?

I added the use of a previously unused variable "language".

I tried several times and I finally got a bid response. Is there any particular reason for this behaviour?

This is our production url, which has some heuristics underneath, which decides whether to yes-bid or no - depending on whether request is valuable for ur or not. We had made it yes-bid more often for the test period (so it did), but making it yes-bid all the time is an additional effort (not required for production), so we try to avoid it.

Oh..I see.
Thanks for clarifying that.

@Fawke Fawke self-requested a review March 11, 2020 16:10
Fawke
Fawke approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 0b75199 into prebid:master Mar 11, 2020
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
36fab76 
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
@redaguermas
Merge branch 'master' into NoBid-Version-1.2.4
031ebf1 
* master: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
@ksanksana
add mediaforce bid adapter (prebid#4933)
dc31056 
* add mediaforce bid adapter

* make use of unused variable language
@Fawke Fawke added LGTM and removed needs update labels Apr 7, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
@ksanksana @rjvelicaria
add mediaforce bid adapter (prebid#4933)
b6b4fbe 
* add mediaforce bid adapter

* make use of unused variable language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fawke Fawke Fawke approved these changes

Assignees

@Fawke Fawke

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksanksana @Fawke @harpere