Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(standard): make genericName optional and deprecate it #146

Merged
merged 1 commit into from
May 2, 2022

Conversation

bfabio
Copy link
Contributor

@bfabio bfabio commented Mar 28, 2022

genericName doesn't really fit software outside Desktop environments
and is often misused in practice. Also, we don't offer any controlled vocabulary
for generic names.

The 'shortDescription' and 'name' keys are good enough.

Fix #59.

genericName doesn't really fit software outside Desktop environments
and is often misused in practice. Also, we don't offer any controlled vocabulary
for generic names.

The 'shortDescription' and 'name' keys are good enough.

Fix publiccodeyml#59.
@bfabio
Copy link
Contributor Author

bfabio commented Mar 28, 2022

@yaml-9000 deprecation-change
@yaml-9000 minor-change

@yaml-9000
Copy link

Thanks for your contribution 🙏

This is now marked as a minor-change proposal to the standard,
this means that old versions of publiccode.yml will still be valid with this change.

Example of minor changes are additions of new keys or making keys optional.

The Chair will eventually pick up this proposal and start the voting procedure using @yaml-9000 vote-start

cc @ruphy @publiccodeyml/steering-committee

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@yaml-9000
Copy link

Thanks for your contribution 🙏

This is now marked as a deprecation-change proposal to the standard, this means that this change won't break any compatibility with the old versions of the Standard,
and it will be possibile to make the definitive change 6 months after the deprecation with a new major release.

The Chair will eventually pick up this proposal and start the voting procedure using @yaml-9000 vote-start

cc @ruphy @publiccodeyml/steering-committee

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@yaml-9000 yaml-9000 added standard-deprecation This change deprecates something in the Standard vote-draft Change proposal to the Standard or to the governance procedures standard-minor-change This change is backward compatible. It's a new feature. labels Mar 28, 2022
@ruphy
Copy link
Member

ruphy commented Apr 13, 2022

@yaml-9000 vote-start

@yaml-9000
Copy link

Voting is now open on this proposal!

If you are a member of the Steering Committee you can now vote!

The polls will stay open for 14 days, until Wed, 27 Apr 2022 13:04:57 GMT.
At the end of that period the Chair (@ruphy) will mark the voting period as over using @yaml-9000 vote-end

Leave a 👍 (thumbs up) on this comment to accept the proposal or a 👎 (thumbs down) to reject it.

cc @publiccodeyml/steering-committee

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@ruphy
Copy link
Member

ruphy commented Apr 29, 2022

@yaml-9000 vote-end

@yaml-9000
Copy link

Vote results

The results of the vote are:

Vote Members Votes count Percentage
👍 Approve @ruphy @bzg 2 100.0%
👎 Reject 0 -

Proposal approved 👍

This proposal is now ready to be merged and get released with a new version of the standard.

cc @ruphy @publiccodeyml/maintainers

Details

First round: unanimity required

The following users voted (includes non-members of the steering committee):

  • ruphy voted 👍

  • bzg voted 👍

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@bfabio bfabio merged commit 68be412 into publiccodeyml:main May 2, 2022
@bfabio bfabio deleted the proposal/generic-name branch May 2, 2022 08:22
bfabio added a commit to bfabio/publiccode-parser-go that referenced this pull request May 10, 2022
bfabio added a commit to bfabio/publiccode-parser-go that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standard-deprecation This change deprecates something in the Standard standard-minor-change This change is backward compatible. It's a new feature. vote-approved vote-draft Change proposal to the Standard or to the governance procedures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing genericName
3 participants