Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dst package #37

Closed
wants to merge 2 commits into from
Closed

Use dst package #37

wants to merge 2 commits into from

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented Apr 12, 2023

This PR uses the dst package (https://github.com/dave/dst) to parse/ manipulate the ast. dst is designed to bind comments to nodes, unlike the original ast package (context: golang/go#20744).

@aq17 aq17 requested review from iwahbe and a team April 12, 2023 20:49
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we have a test of this migration before we merge this into main.

@aq17
Copy link
Contributor Author

aq17 commented Apr 13, 2023

@iwahbe I'm working on adding a test right now.

pulumi/pulumi-databricks#94 was generated with this.

@iwahbe
Copy link
Member

iwahbe commented Apr 13, 2023

@iwahbe I'm working on adding a test right now.

pulumi/pulumi-databricks#94 was generated with this.

pulumi/pulumi-databricks#94 looks like a good PR, but it doesn't have any code migrations in it.

@aq17
Copy link
Contributor Author

aq17 commented Apr 13, 2023

Oh pulumi-databricks already had auto aliasing implemented. I'll try on another provider

@aq17
Copy link
Contributor Author

aq17 commented Apr 14, 2023

Closing in favor of #39.

@aq17 aq17 closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants