gh-74690: Add more tests for runtime-checkable protocols #103347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
tests
AlexWaygood
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
carljm
approved these changes
Apr 7, 2023
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2023
…nGH-103347) (cherry picked from commit 800382a) Co-authored-by: Alex Waygood <[email protected]>
|
GH-103350 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 7, 2023
(cherry picked from commit 800382a) Co-authored-by: Alex Waygood <[email protected]>
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for runtime-checkable protocols, ensuring various edge cases are covered. Some of the invariants I'm adding tests for would have been broken by some more hare-brained optimisations that we considered, but rejected, in #74690 and #103310.