Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104797: Allow Protocols to inherit from collections.abc.Buffer #104827

Merged
merged 3 commits into from
May 24, 2023
Merged

gh-104797: Allow Protocols to inherit from collections.abc.Buffer #104827

merged 3 commits into from
May 24, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 24, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 24, 2023
AlexWaygood
AlexWaygood approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) May 24, 2023 06:23
@AlexWaygood AlexWaygood merged commit c0ab7d4 into python:main May 24, 2023
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@JelleZijlstra @miss-islington
pythongh-104797: Allow Protocols to inherit from collections.abc.Buff…
42a05db 
…er (pythonGH-104827)

(cherry picked from commit c0ab7d4)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot
Copy link

GH-104841 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 24, 2023
AlexWaygood pushed a commit that referenced this pull request May 24, 2023
@miss-islington @JelleZijlstra
[3.12] gh-104797: Allow Protocols to inherit from collections.abc.Buf…
d10d1e3 
…fer (GH-104827) (#104841)

gh-104797: Allow Protocols to inherit from collections.abc.Buffer (GH-104827)
(cherry picked from commit c0ab7d4)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@AlexWaygood AlexWaygood mentioned this pull request Jun 4, 2023
Merged
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use multiple inheritance with collections.abc.Buffer and typing.Protocol
4 participants
@JelleZijlstra @miss-islington @bedevere-bot @AlexWaygood