Allow Protocols to inherit from typing_extensions.Buffer or collections.abc.Buffer #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Jun 4, 2023
AlexWaygood
changed the title
AlexWaygood
commented
Jun 4, 2023
Comment on lines
+2740
to
+2744
| @skipUnless( | ||
| hasattr(collections.abc, "Buffer"), | ||
| "needs collections.abc.Buffer to exist" | ||
| ) | ||
| @skip_if_py312b1 |
There was a problem hiding this comment.
This test isn't run in CI at all right now, but I've confirmed locally that it passes with the CPython main branch (so when 3.12b2 comes along, it should pass in CI for us here)
srittau
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of python/cpython#104827