Bump for 1.27 k8s compat #65
Conversation
| k8s.io/apimachinery v0.26.4 | ||
| github.com/stretchr/testify v1.8.4 | ||
| k8s.io/api v0.27.5 | ||
| k8s.io/apimachinery v0.27.5 | ||
| k8s.io/client-go v12.0.0+incompatible |
There was a problem hiding this comment.
What's the reason for using this v12... version of client-go instead of v0.27.5?
There was a problem hiding this comment.
This is overridden by the replace directive above: https://github.com/rancher/csp-adapter/pull/65/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R13. Rancher/rancher uses a similar system: https://github.com/rancher/rancher/blob/564fbe67d735feab5064f8bc4cbd42df730fe550/go.mod#L152.
I'd appreciate it if you could focus on the changes which this PR made - given the status of the repo and the urgency of this I think it makes sense to focus on the new-side changes rather than re-evaluating prior decisions.
There was a problem hiding this comment.
I think it doesn't matter because this gets replaced in the replace directive:
replace (
...
k8s.io/client-go => github.com/rancher/client-go v1.27.4-rancher1
EDIT: You beat me to it.
Bumps the go version to 1.20, the lasso version, and the underlying k8s libraries for 1.27 support
MbolotSuse
force-pushed
the
1.27-compat
branch
from
2604ae2
to
dda9141
Compare
Bumps the go version to 1.20, the lasso version, and the underlying k8s libraries for 1.27 support