Bump to 1.27 k8sversion for 2.7 release #77
Conversation
| @@ -13,4 +13,4 @@ annotations: | |||
| catalog.cattle.io/os: linux | |||
| catalog.cattle.io/permits-os: linux | |||
| catalog.cattle.io/rancher-version: '>= 2.7.0-0 < 2.8.0-0' | |||
| catalog.cattle.io/kube-version: '>= 1.22.0-0 < 1.27.0-0' | |||
| catalog.cattle.io/kube-version: '>= 1.22.0-0 < 1.28.0-0' | |||
There was a problem hiding this comment.
Shouldn't it be catalog.cattle.io/kube-version: '>= 1.23.0-0 < 1.28.0-0'
There was a problem hiding this comment.
As far as I know, the 1.23 min version is applicable for v2.8 release and not for the v2.7. Michael can confirm this.
Also I do anticipate more changes to this PR as and when rancher core will be adding support for 1.27 k8s version for the v2.7.x release.
There was a problem hiding this comment.
Typically we avoid dropping support for a minor version on a patch version. That being said, reviewing the support matrix 1.23 appears to be the lowest supported version so it might be best to update this to bring this in line with the rest of the 2.7 line.
There was a problem hiding this comment.
You will also need to update the versions of client-go (among other things) used in this application - see #65 for an example of this.
Bumps the go version to 1.20, the lasso version, and the underlying k8s libraries for 1.27 support
mbelur
force-pushed
the
bump-k8s-release2.7
branch
2 times, most recently
from
288da2f
to
f9d4122
Compare
mbelur
force-pushed
the
bump-k8s-release2.7
branch
from
f9d4122
to
bb2e7b4
Compare
There was a problem hiding this comment.
LGTM. One note, this did pull in slightly different dependencies for some packages (like golang.org/x/sys which on the 2.8 side is version 0.10.0 and here is 0.11.0) than the PR for 2.8. That's probably due to the BCI golang image being updated since the 2.8 PR was made. It's not a big problem, just make sure you do some basic regression testing some time before release.
No description provided.