Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iOS): remove unintended flags from build-ios #2078

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

thymikee
Copy link
Member

Summary:

The build-ios command contained some left-over flags from run-ios like simulator, uuid, device. Removed the references and moved the code a bit to remove duplication.

As a followup we should focus on bringing interactive behavior as default

Test Plan:

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the docs Documentation change label Sep 18, 2023
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup! 🙌 I still see some flags such us --binary-path or --list-devices under build-ios command instead of run-ios in docs ;/ We need to fully sync docs with codebase.

Copy link
Collaborator

@adamTrz adamTrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, works like a charm 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants