Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get scheme from xcodeProject name #2121

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Oct 13, 2023

Summary:

Fixes #2115
Regression introduced in #2078

Reverts this code that was used in 0.72:

const inferredSchemeName = path.basename(
xcodeProject.name,
path.extname(xcodeProject.name),
);
let scheme = args.scheme || inferredSchemeName;

Test Plan:

git clone https://github.com/microsoft/react-native-test-app.git
cd react-native-test-app
npm run set-react-version 0.73 -- --core-only
yarn
cd example
pod install --project-directory=ios

# Link CLI locally following CONTRIBUTING.md
# Because of an issue with finding CocoaPods, you may have to remove line 51
# packages/cli-platform-ios/src/commands/runIOS/index.ts

yarn ios

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak
Copy link
Collaborator Author

@tido64 Mind looking at these changes? 🙏 I tested this in RNTA, and it seems to be working correctly.

Copy link
Contributor

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I had to disable automatic pod install (which is fixed in #2121), but react-native run-ios passes now. Tested against 0.73.0-rc.2.

I left a few nits.

@thymikee thymikee merged commit fc33507 into main Oct 26, 2023
6 checks passed
@thymikee thymikee deleted the fix/get-scheme-from-path branch October 26, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native run-ios fails on 0.73 trying to find Xcode schemes
4 participants