Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error building iOS with v1.0.x & old arch #751

Closed
swrobel opened this issue Apr 12, 2024 · 13 comments · Fixed by #794
Closed

Fatal error building iOS with v1.0.x & old arch #751

swrobel opened this issue Apr 12, 2024 · 13 comments · Fixed by #794

Comments

@swrobel
Copy link

swrobel commented Apr 12, 2024

node_modules/@react-native-menu/menu/ios/MenuViewManager.mm:10:9: fatal error: 'react_native_menu-Swift.h' file not found
#import <react_native_menu-Swift.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~

This seems to have been broken by #682 cc @SudoPlz

react-native-menu 1.0.0
react-native 0.73.6

@fobos531
Copy link
Contributor

also see #750

@hollanderbart

This comment was marked as abuse.

@fobos531
Copy link
Contributor

Sorry for the negativity, but how can software be released this way? It surprises me each time.

For what it's worth, I just tried building the application on iOS and old arch (RN 0.73.6), and it worked just fine for me with v1.0.0

@antoniogoulao
Copy link

antoniogoulao commented Apr 16, 2024

My workaround was to lower the version on package.json back to 0.9.1 and it worked again on iOS.

@marcoizzo
Copy link

same issue here

@b0iq
Copy link

b0iq commented Apr 22, 2024

1.0.1 still happening

@fobos531
Copy link
Contributor

Can confirm, this is happening for me as well on 1.0.1 and react native 0.73.7

@swrobel swrobel changed the title Fatal error building iOS with v1.0.0 & old arch Fatal error building iOS with v1.0.x & old arch Apr 23, 2024
@swrobel
Copy link
Author

swrobel commented Apr 23, 2024

@SudoPlz could you please take a look at this

@Myst1024
Copy link

Myst1024 commented Apr 24, 2024

I was able to resolve this issue by updating MenuViewManager.mm:

 #import "MenuView.h"
 #else
 // OLD ARCH
-#import <react_native_menu-Swift.h>
+#import <react_native_menu/react_native_menu-Swift.h>
 #endif
 
 @interface MenuViewManager : RCTViewManager

@swrobel
Copy link
Author

swrobel commented Apr 25, 2024

@Myst1024 cool! Have you considered submitting as a PR?

@Silvan-M
Copy link

Silvan-M commented May 1, 2024

Also facing same problem, doing fix by @Myst1024 works. However it seems as if it needs to be changed after every run of pod install. PR would be great!

Gregoirevda added a commit to Gregoirevda/rn-menu that referenced this issue May 3, 2024
@JustJoostNL
Copy link

@Naturalclar can you consider reopening this? The problem still exists, see:

#794 (comment)
#794 (comment)

@JuanRdBO
Copy link
Contributor

Still exists for me as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants