Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MenuViewManager.mm #794

Merged
merged 1 commit into from
May 3, 2024

Conversation

Gregoirevda
Copy link
Contributor

Fixes #751

Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Naturalclar Naturalclar merged commit 9013a4b into react-native-menu:master May 3, 2024
@JClackett
Copy link

any idea when we can expect a release? 🙌🏾

@Naturalclar
Copy link
Member

@JClackett released in v1.0.2 🚀

@JClackett
Copy link

Hmm yeah I've been trying this but still getting this in 1.0.2:

❌  (../../node_modules/@react-native-menu/menu/ios/MenuViewManager.mm:10:9)

   8 | #else
   9 | // OLD ARCH
> 10 | #import <react_native_menu/react_native_menu-Swift.h>
     |         ^ 'react_native_menu/react_native_menu-Swift.h' file not found
  11 | #endif
  12 | 
  13 | @interface MenuViewManager : RCTViewManager

@JustJoostNL
Copy link

JustJoostNL commented May 7, 2024

Same issue here still on latest version.

(node_modules/@react-native-menu/menu/ios/MenuViewManager.mm:10:9)

   8 | #else
   9 | // OLD ARCH
> 10 | #import <react_native_menu/react_native_menu-Swift.h>
     |         ^ 'react_native_menu/react_native_menu-Swift.h' file not found
  11 | #endif
  12 | 

@swrobel
Copy link

swrobel commented May 7, 2024

It is a bit odd that although this fixed my iOS build issues, the react_native_menu-Swift.h file doesn't seem to exist anywhere, regardless of the path.

@JuanRdBO
Copy link
Contributor

Still exists for me

@Gregoirevda
Copy link
Contributor Author

@JuanRdBO seems to be fixed in 1.0.3

@JuanRdBO
Copy link
Contributor

@JuanRdBO seems to be fixed in 1.0.3

Sadly this still happens to me on 1.0.3 :-/

@JustJoostNL
Copy link

JustJoostNL commented May 15, 2024

Yup same here

@Gregoirevda
Copy link
Contributor Author

1.0.2 included this fix and 1.0.3 went back to

#import <react_native_menu-Swift.h>

But the convention is <ProductName/ProductModuleName-Swift.h> which should be:

#import <react_native_menu/react_native_menu-Swift.h>

Could you confirm this works and it would then be good to revert the change @svbutko

@Gregoirevda
Copy link
Contributor Author

@JustJoostNL @JuanRdBO Does it work if you downgrade to 1.0.2, pod install and build?

@JuanRdBO
Copy link
Contributor

JuanRdBO commented May 15, 2024

@JustJoostNL @JuanRdBO Does it work if you downgrade to 1.0.2, pod install and build?

It works with 1.0.2! I think we should revert the change

@JClackett
Copy link

1.0.3 is working now

@svbutko
Copy link
Contributor

svbutko commented May 15, 2024

@Gregoirevda the problem is that one change works in NEW ARCH but breaks OLD ARCH and vice versa, this should be addressed differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error building iOS with v1.0.x & old arch
7 participants