fix: codeCompletion-with-defaultSnippet-and-makdown #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
requested review from
evidolob,
joshuawilson and
JPinkney
as code owners
JPinkney
reviewed
Jan 5, 2021
There was a problem hiding this comment.
I think we will probably have to check the client capabilities similar to how vscode-json-languageservice does it: https://github.com/microsoft/vscode-json-languageservice/blob/36f8016a33df9eff3b6edd584605aea349b73745/src/services/jsonCompletion.ts#L968. Just to make sure that the client supports markdown before setting supportsMarkdown = true
- copy functionality from original yaml-service
|
You are absolutely right! So I used functionality from original json-service. |
JPinkney
reviewed
Jan 6, 2021
Co-authored-by: Josh Pinkney <[email protected]>
- first init with Capabilities.LATEST
evidolob
reviewed
Jan 11, 2021
JPinkney
approved these changes
Jan 11, 2021
evidolob
approved these changes
Jan 11, 2021
p-spacek
deleted the
fix/codeCompletion-with-defaultSnippet-and-makdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
enable defaultSnippet markdown description in schemas for code completion service
What issues does this PR fix or reference?
when schema has defaultSnippet and markdown description parameter set, jsonCompletion will ignores this markdown description because of undefined parameter
supportsMarkdownIs it tested? How?
added unit-test