fix codeCompletion with defaultSnippet and makdown #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
requested review from
evidolob,
joshuawilson and
JPinkney
as code owners
JPinkney
approved these changes
Jan 15, 2021
evidolob
approved these changes
Jan 15, 2021
aeschli
pushed a commit
to aeschli/yaml-language-server
that referenced
this pull request
Jun 23, 2021
Signed-off-by: Yevhen Vydolob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix previous PR #385 'enable defaultSnippet markdown description in schemas for code completion service'
the problem is there
What issues does this PR fix or reference?
fix previous PR
move
collectDefaultSnippetsinto 'array' conditionIs it tested? How?
added unite test