-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: mgmt9855 deploy MCE and ACM2.5 #406
Conversation
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
This reverts commit 5398b6e.
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
…meout Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alberto and I have been testing this PR heavily every day on multiple architectures.
The PR is quite big so I will go ahead and merge it to avoid future conflicts, let it sit through the weekend, and get ready to face Monday failures after a good rest over the weekend.
Alberto did a good job summarizing what's been tested, what works, what the defaults are, etc. There is still more work to do but we will start with merging this and then fix what's left.
Once this PR goes in, we will need to update the hub clusters we have so that we have all the CI servers aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, let's test it
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This PR allows the integration of ACM2.5 and MCE into the pipeline workflow assuming this:
2 pipelines: 1 for acm2.5 (which includes mce as a dependency) and 1 for MCE
1. Pipeline ACM -> Step ACM2.5 + Step Hub configs (default to pass CI tests PR -> ACM2.5)
2. Pipeline MCE -> Step MCE + Step Hub configs
ACM using version 2.5 (deprecating 2.4): ACM2.5 depends on MCE so makes sense to have the configs within MCE namespace (if you want to use only mce without acm with this model you could use it). It's means that in code, the namespace for hub configs will change to multicluster-engine namespace instead of the open-cluster-management. This is one of the reason to deprecate the 2.4 when we will merge this PR.
ocp version 4.10.20 used and established in the auto-config yaml file for edgecluster
#UPDATED:
New Tests done:
MCE + sno 2 nics (ovn) -> OK tested successfully
MCE + comapct 2 nics (sdn) -> OK tested successfully
ACM + sno 2 nics (ovn) -> OK tested successfully
ACM + compact 2 nics (sdn) -> OK tested successfully
merge this PR and then prepare a new one (PR for patching with 1 nic):
ACM + sno 1 nics (ovn)
ACM + compact 1 nics (sdn)
MCE + sno 1 nics (ovn) ->
MCE + compact 1 nics (sdn)
Fixes # https://issues.redhat.com/browse/MGMT-9855
Type of change
Please select the appropriate options:
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
HUB Test MCE pipeline (without ACM2.5) -> Check Pods Assisted
![image](https://user-images.githubusercontent.com/9356454/174948839-12ac7195-1587-485e-8096-e7e4aac55251.png)
![image](https://user-images.githubusercontent.com/9356454/174956075-ca886b10-3072-4759-a1f7-051b345d0f01.png)
![image](https://user-images.githubusercontent.com/9356454/174956169-28cb06cb-0831-453c-940e-eeec11d10541.png)
HUB Test ACM2.5 pipeline with MCE integrated -> Check Pods Assisted
After apply the fix to sno and isolated (trying to do only for sno) the next tests should be:
hub ACM2.5 + edge compact (sdn)
![image](https://user-images.githubusercontent.com/9356454/175003289-224c4744-ad26-4419-812d-2277b29a5dcb.png)
![image](https://user-images.githubusercontent.com/9356454/175003215-f9691f1f-63af-4068-914a-48ef2557208b.png)
![image](https://user-images.githubusercontent.com/9356454/175281482-9045770e-7de3-4280-a1a5-da21dee7c9fa.png)
hub MCE + edge compact (sdn)
![image](https://user-images.githubusercontent.com/9356454/175511654-d7afed56-2ed5-44b8-ba4c-3433816f0b6b.png)
![image](https://user-images.githubusercontent.com/9356454/175512262-231e993c-f87a-4bb6-a206-13318d3a96d5.png)
hub MCE + edge compact (ovn)
hub ACM2.5 + edge sno + sdn + no-isolated. (ONLY WORKS WITH 2 INTERFACES)
![image](https://user-images.githubusercontent.com/9356454/175306924-0d8acd4f-c528-4c5d-b6af-e33c2256421c.png)
![image](https://user-images.githubusercontent.com/9356454/175311882-4fdb7fd7-98d0-452b-b454-683ce373a7ae.png)
![image](https://user-images.githubusercontent.com/9356454/175542871-91c091b8-4915-45d9-962a-398469400569.png)
1 INTERFACE KO
2 INTERFACES OK:
![image](https://user-images.githubusercontent.com/9356454/175497494-a310755a-59fd-4ac5-a667-b64cd9d240c0.png)
![image](https://user-images.githubusercontent.com/9356454/175497519-4b9528e5-d086-44b6-8a3c-15388ac687be.png)
![image](https://user-images.githubusercontent.com/9356454/175497571-f6712f4a-69ec-4d44-bb27-064e333ea8c4.png)
1 interface KO same than with ACM2.5 + edge sno + ovn + no-isolated:
2 interfaces:
![image](https://user-images.githubusercontent.com/9356454/175542673-7598b86c-0c37-4a12-96ca-af9a48df52cf.png)
![image](https://user-images.githubusercontent.com/9356454/175551396-5fcaaf95-7034-496f-a84a-712c85427af6.png)
The rest of combinations are tested with these tests
Test Configuration:
Checklist