Feat: mgmt9855 deploy MCE and ACM2.5

[alknopfler]

Description

This PR allows the integration of ACM2.5 and MCE into the pipeline workflow assuming this:

• 2 pipelines: 1 for acm2.5 (which includes mce as a dependency) and 1 for MCE
  1. Pipeline ACM -> Step ACM2.5 + Step Hub configs (default to pass CI tests PR -> ACM2.5)
  2. Pipeline MCE -> Step MCE + Step Hub configs

• ACM using version 2.5 (deprecating 2.4): ACM2.5 depends on MCE so makes sense to have the configs within MCE namespace (if you want to use only mce without acm with this model you could use it). It's means that in code, the namespace for hub configs will change to multicluster-engine namespace instead of the open-cluster-management. This is one of the reason to deprecate the 2.4 when we will merge this PR.

• ocp version 4.10.20 used and established in the auto-config yaml file for edgecluster

#UPDATED:

• There's a issue/bz https://issues.redhat.com/browse/SDN-3053 with OVN and SNO regarding to the 2 nics and default routes in our use case to choose an specific interface when ovn has 2 interfaces/ default routes, so we're assuming that only for SNO the network will not be isolated until ovn team will fix the issue and we could revert this change.
• For all tests we will test it with OVN, assuming that the SNO will fail, and we will create a new commit to remove the network isolation after this one

New Tests done:

• MCE + sno 2 nics (ovn) -> OK tested successfully

• MCE + comapct 2 nics (sdn) -> OK tested successfully

• ACM + sno 2 nics (ovn) -> OK tested successfully

• ACM + compact 2 nics (sdn) -> OK tested successfully
  merge this PR and then prepare a new one (PR for patching with 1 nic):

• ACM + sno 1 nics (ovn)

• ACM + compact 1 nics (sdn)

• MCE + sno 1 nics (ovn) ->

• MCE + compact 1 nics (sdn)

Fixes # https://issues.redhat.com/browse/MGMT-9855

Type of change

Please select the appropriate options:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• This change is a documentation update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• HUB Test MCE pipeline (without ACM2.5) -> Check Pods Assisted
  
  
  

• HUB Test ACM2.5 pipeline with MCE integrated -> Check Pods Assisted

After apply the fix to sno and isolated (trying to do only for sno) the next tests should be:

• hub ACM2.5 + edge compact (sdn)
  
  
  

• hub MCE + edge compact (sdn)
  
  

• hub MCE + edge compact (ovn)

• hub ACM2.5 + edge sno + sdn + no-isolated. (ONLY WORKS WITH 2 INTERFACES)
  1 INTERFACE KO
  
  
  

2 INTERFACES OK:

• hub MCE + edge sno + sdn + no-isolated:
  1 interface KO same than with ACM2.5 + edge sno + ovn + no-isolated:
  

2 interfaces:

The rest of combinations are tested with these tests

Test Configuration:

• Versions: image quay.io/ztpfw/pipeline:feat_mgmt9855_deploy_mce
• Hardware: Flavio3

Checklist

• I have performed a self-review of my own code
• If a change is adding a feature, it should require a change to the README.md and the review should catch this.
• If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
• A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
• PRs should not be merged unless positively reviewed.

[flaper87]

Alberto and I have been testing this PR heavily every day on multiple architectures.

The PR is quite big so I will go ahead and merge it to avoid future conflicts, let it sit through the weekend, and get ready to face Monday failures after a good rest over the weekend.

Alberto did a good job summarizing what's been tested, what works, what the defaults are, etc. There is still more work to do but we will start with merging this and then fix what's left.

Once this PR goes in, we will need to update the hub clusters we have so that we have all the CI servers aligned.

[iranzo]

Looks fine, let's test it

[iranzo]

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀