Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 1 nic to mce (ovn) #462

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

add 1 nic to mce (ovn) #462

wants to merge 12 commits into from

Conversation

alknopfler
Copy link
Contributor

@alknopfler alknopfler commented Jul 1, 2022

Signed-off-by: Alberto Morgante Medina [email protected]

Description

This PR is the second part of the PR #406
Allows the feature to use 1 nic instead of 2 using vlan with ovn and sdn

Fixes # mgmt9855

Type of change

Please select the appropriate options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • ACM + sno 1 nics (ovn)
  • ACM + compact 1 nics (ovn)
  • MCE + sno 1 nics (ovn) ->
  • MCE + compact 1 nics (ovn)

Test Configuration:

  • Versions:
  • Hardware:

Checklist

  • I have performed a self-review of my own code
  • If a change is adding a feature, it should require a change to the README.md and the review should catch this.
  • If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
  • A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
  • PRs should not be merged unless positively reviewed.

Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
@github-actions github-actions bot added size/M and removed size/XS labels Jul 8, 2022
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
Signed-off-by: Alberto Morgante Medina <[email protected]>
@alknopfler alknopfler changed the title add 1 nic to mce add 1 nic to mce (ovn) Jul 14, 2022
@alknopfler alknopfler added the Hold Dont merge this yet! label Jul 14, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant