Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Silence warnings when building LLVM and clang #15483

Closed
wants to merge 1 commit into from
Closed

[CMake] Silence warnings when building LLVM and clang #15483

wants to merge 1 commit into from

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented May 11, 2024 •
edited
Loading

Suppress warnings compiling the builtin LLVM and clang. It is not
maintained by ROOT, so warnings are not necessary here.

This suppresses many warnings that flood the build logs, and also
prevent us from treating warnings as errors in the CI.

@guitargeek guitargeek self-assigned this May 11, 2024
@guitargeek guitargeek requested a review from bellenot as a code owner May 11, 2024 00:14
@guitargeek guitargeek force-pushed the clang_warnings branch 2 times, most recently from d12c720 to 843eb95 Compare May 11, 2024 00:20
@github-actions GitHub Actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

Test Results

    11 files      11 suites   2d 7h 27m 30s ⏱️
 2 635 tests  2 635 ✅ 0 💤 0 ❌
27 419 runs  27 419 ✅ 0 💤 0 ❌

Results for commit c88aebb.

♻️ This comment has been updated with latest results.

@guitargeek guitargeek added this to the 6.32/00 milestone May 11, 2024
hahnjo
hahnjo requested changes May 13, 2024
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must not be merged like this, it would need synchronization to our llvm-project fork as indicated by the llvm-diff workflow. It would be better to add these flags on the ROOT side, in interpreter/CMakeLists.txt and not modify upstream LLVM sources.

@hahnjo hahnjo mentioned this pull request May 13, 2024
Merged
@guitargeek guitargeek requested a review from hahnjo May 15, 2024 14:21
@guitargeek guitargeek force-pushed the clang_warnings branch 2 times, most recently from c93616b to c92bfce Compare May 15, 2024 15:24
@guitargeek
[CMake] Silence warnings when building LLVM and clang
c88aebb 
Suppress warnings compiling the builtin LLVM and clang. It is not
maintained by ROOT, so warnings are not necessary here.

This suppresses many warnings that flood the build logs, and also
prevent us from treating warnings as errors in the CI.
@guitargeek guitargeek changed the title [clang] Silence some warnings when building clang with external llvm [CMake] Silence warnings when building LLVM and clang May 15, 2024
hahnjo added a commit to hahnjo/root that referenced this pull request May 16, 2024
@hahnjo
[interpreter] Avoid GCC notes about misleading-indentation
5f8f7de 
Some LLVM source files are very large, leading to notes by GCC that
"-Wmisleading-indentation is disabled from this point onwards."

Approach taken from root-project#15483
Co-authored-by: Jonas Rembser <[email protected]>
@hahnjo hahnjo mentioned this pull request May 16, 2024
Merged
@hahnjo
Copy link
Member

hahnjo commented May 16, 2024

For the case of builtin_llvm=OFF builtin_clang=ON, there is an easier solution by properly (re)setting LLVM_ENABLE_WARNINGS: #15527

@guitargeek
Copy link
Contributor Author

Closing in favor of a better solution #15527.

@guitargeek guitargeek closed this May 16, 2024
@guitargeek guitargeek deleted the clang_warnings branch May 16, 2024 10:25
hahnjo added a commit that referenced this pull request May 16, 2024
@hahnjo
[interpreter] Avoid GCC notes about misleading-indentation
794c30a 
Some LLVM source files are very large, leading to notes by GCC that
"-Wmisleading-indentation is disabled from this point onwards."

Approach taken from #15483
Co-authored-by: Jonas Rembser <[email protected]>
guitargeek pushed a commit to guitargeek/root that referenced this pull request May 16, 2024
@hahnjo @guitargeek
[interpreter] Avoid GCC notes about misleading-indentation
155a53f 
Some LLVM source files are very large, leading to notes by GCC that
"-Wmisleading-indentation is disabled from this point onwards."

Approach taken from root-project#15483
Co-authored-by: Jonas Rembser <[email protected]>
guitargeek pushed a commit that referenced this pull request May 16, 2024
@hahnjo @guitargeek
[interpreter] Avoid GCC notes about misleading-indentation
99d6503 
Some LLVM source files are very large, leading to notes by GCC that
"-Wmisleading-indentation is disabled from this point onwards."

Approach taken from #15483
Co-authored-by: Jonas Rembser <[email protected]>
PPaye pushed a commit to PPaye/root that referenced this pull request Jun 3, 2024
@hahnjo
[interpreter] Avoid GCC notes about misleading-indentation
7715aa8 
Some LLVM source files are very large, leading to notes by GCC that
"-Wmisleading-indentation is disabled from this point onwards."

Approach taken from root-project#15483
Co-authored-by: Jonas Rembser <[email protected]>
silverweed pushed a commit to silverweed/root that referenced this pull request Aug 19, 2024
@hahnjo
[interpreter] Avoid GCC notes about misleading-indentation
4415acd 
Some LLVM source files are very large, leading to notes by GCC that
"-Wmisleading-indentation is disabled from this point onwards."

Approach taken from root-project#15483
Co-authored-by: Jonas Rembser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@hahnjo hahnjo Awaiting requested review from hahnjo

Assignees

@guitargeek guitargeek

Labels
None yet
Projects
None yet
Milestone
6.32/00
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guitargeek @hahnjo