-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] Silence warnings when building LLVM and clang #15483
Conversation
d12c720
to
843eb95
Compare
Test Results 11 files 11 suites 2d 7h 27m 30s ⏱️ Results for commit c88aebb. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must not be merged like this, it would need synchronization to our llvm-project
fork as indicated by the llvm-diff
workflow. It would be better to add these flags on the ROOT side, in interpreter/CMakeLists.txt
and not modify upstream LLVM sources.
843eb95
to
f2076fb
Compare
c93616b
to
c92bfce
Compare
Suppress warnings compiling the builtin LLVM and clang. It is not maintained by ROOT, so warnings are not necessary here. This suppresses many warnings that flood the build logs, and also prevent us from treating warnings as errors in the CI.
c92bfce
to
c88aebb
Compare
Some LLVM source files are very large, leading to notes by GCC that "-Wmisleading-indentation is disabled from this point onwards." Approach taken from root-project#15483 Co-authored-by: Jonas Rembser <[email protected]>
For the case of |
Closing in favor of a better solution #15527. |
Some LLVM source files are very large, leading to notes by GCC that "-Wmisleading-indentation is disabled from this point onwards." Approach taken from #15483 Co-authored-by: Jonas Rembser <[email protected]>
Some LLVM source files are very large, leading to notes by GCC that "-Wmisleading-indentation is disabled from this point onwards." Approach taken from root-project#15483 Co-authored-by: Jonas Rembser <[email protected]>
Some LLVM source files are very large, leading to notes by GCC that "-Wmisleading-indentation is disabled from this point onwards." Approach taken from #15483 Co-authored-by: Jonas Rembser <[email protected]>
Some LLVM source files are very large, leading to notes by GCC that "-Wmisleading-indentation is disabled from this point onwards." Approach taken from root-project#15483 Co-authored-by: Jonas Rembser <[email protected]>
Some LLVM source files are very large, leading to notes by GCC that "-Wmisleading-indentation is disabled from this point onwards." Approach taken from root-project#15483 Co-authored-by: Jonas Rembser <[email protected]>
Suppress warnings compiling the builtin LLVM and clang. It is not
maintained by ROOT, so warnings are not necessary here.
This suppresses many warnings that flood the build logs, and also
prevent us from treating warnings as errors in the CI.