[v632] Backport of recent fixes and improvements #15486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
bellenot,
lmoneta,
dpiparo and
vepadulano
as code owners
Test Results 9 files 9 suites 1d 20h 34m 11s ⏱️ Results for commit 7ca32f5. |
hahnjo
requested changes
May 13, 2024
There was a problem hiding this comment.
Please see #15483 (review); IMHO commits should only be backported once they landed in master...
|
Sure! I just opened the PR already because it's easy to do in one go, and then I don't forget it later :) If the master commits get some changes because of review requests, it's easy to update the backport PR and merge once the master PRs are merged. Also, I can get 6.32 test coverage already. |
Function was removed here root-project/cling@c23abbc Fixes root-project/cling#456
Thanks to this forum post: https://root-forum.cern.ch/t/extended-option-removed-from-fitto-and-createnll/59283 Needs to be backported to 6.32 and 6.30.
Closes root-project#15153, as confirmed in this comment: root-project#15153 (comment)
…s raise C++ exceptions of the same type
Import some of the changes applied in 6.28 from commit root-project@c2cacce
guitargeek
force-pushed
the
backports_v632
branch
from
7ca32f5
to
3ac8f15
Compare
guitargeek
merged commit 3c60d2d
into
root-project:v6-32-00-patches
11 of 13 checks passed
|
The commits that are not merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of recent fixes and improvements. The fix for the cppyy regression is important in particular.