[ntuple] Remove incorrect std::vector::reserve #16069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in commit d950e99 ("[ntuple] use RClusterPool in RNTupleMerger") with no explicit mention, and I believe it's wrong because every column yields exactly one page group that contains all pages for that column.
silverweed
approved these changes
Jul 19, 2024
Test Results 13 files 13 suites 2d 19h 32m 19s ⏱️ For more details on these failures, see this check. Results for commit 64f0389. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in commit d950e99 ("[ntuple] use RClusterPool in RNTupleMerger") with no explicit mention, and I believe it's wrong because every column yields exactly one page group that contains all pages for that column.