-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sh emulation in setup.zsh breaks my zsh config #686
Comments
Since it reset the emulate mode afterwards (a301219) I don't see how that would conflict with your zsh configuration. It might be worth to track down what exactly conflicts for you since it can't be changed in |
Alright, I will dig to find the exact problem and try to provide a minimal broken zshrc. |
I found the problem. Either
|
It looks like we were depending on I created a new PR for it: #692 |
Awesome, thanks. |
This breaks it for my setup. I have the zsh option
PR following. |
source in emulation mode (really fix #686)
Follow change cartographer-project/cartographer#839 from string to struct SensorId. Compute expected sensor ids for multiple trajectories. Remove command argument input for sensor ids. Make some methods const. Clean up.
The
emulate sh
in setup.zsh breaks something in my zsh config. I think it's something in my prompt since I get an error message at every prompt. I haven't pinpointed the problem though because I have a rather large configuration, and removing theemulate sh
fixed the problem for me.Is there a reason for the
emulate sh
? If there is I can dig and find out what exactly is conflicting, but it seems likely than most sh code will work without modification in zsh, without having zsh emulate sh.The text was updated successfully, but these errors were encountered: