find libraries by name instead of using the imported location #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of directly using an imported location we use the soname if possible and after that the location name to find the library using the location directory as hint. This allows us to use an soname, which may be different and to the location name (and residing directory). This allows to use system installed libraries which may be updated but are compatible with the one used at built time as long as the location and name in which they were found in are the same.
traversaro
added a commit
to traversaro/ros-noetic
that referenced
this pull request
Dec 29, 2022
Backport ros/catkin#1142 Fix RoboStack#318
Tobias-Fischer
pushed a commit
to RoboStack/ros-noetic
that referenced
this pull request
Jan 2, 2023
Backport ros/catkin#1142 Fix #318
peci1
suggested changes
Oct 25, 2023
Previously found library will use hint instead of previous search Co-authored-by: Martin Pecka <[email protected]>
devrite
force-pushed
the
1141-catkin-package-depends-imported-by-location
branch
from
09c2469
to
113b921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1141
Instead of directly using an imported location we use
the soname if possible and after that the location name
to find the library using the location directory as hint.
This allows us to use an soname, which may be different
and to the location name (and residing directory). This
allows to use system installed libraries which may be updated
but are compatible with the one used at built time
as long as the location and name in which they were found in
are the same.