Import setuptools before distutils #1176
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setuptools wants to be imported before distutils, and prints a warning if it is not. Starting with a recent version (>57.2, <=61.2), not following this rule causes catkin's own monkey patching to fail. This commit reverses the import order to fix the warning and patching issue.
|
Can you please supply a list of commands to run and the necessary environment to verify this change works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setuptools wants to be imported before distutils, and prints a warning if it is not. Starting with a recent version (>57.2, <=61.2), not following this rule causes catkin's own monkey patching to fail. This commit reverses the import order to fix the warning and patching issue.