Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP zero_ptr in no_std contest #10017

Closed
matthiaskrgr opened this issue Dec 1, 2022 · 0 comments · Fixed by #10023
Closed

FP zero_ptr in no_std contest #10017

matthiaskrgr opened this issue Dec 1, 2022 · 0 comments · Fixed by #10023
Labels
C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied

Comments

@matthiaskrgr
Copy link
Member

Summary

Not sure if this is a valid usecase 🤔

Lint Name

zero-ptr

Reproducer

I tried this code:

#![crate_type = "rlib"]
#![no_std]

#[inline]
pub unsafe fn allocate(_size: usize, _align: usize) -> *mut u8 { 0 as *mut u8 }

I saw this happen:

    Checking imcrate v0.1.0 (/tmp/imcrate)
warning: failed to automatically apply fixes suggested by rustc to crate `imcrate`

after fixes were automatically applied the compiler reported errors within these files:

  * src/main.rs

This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You're likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/rust/issues
quoting the full output of this command we'd be very appreciative!
Note that you may be able to make some more progress in the near-term
fixing code with the `--broken-code` flag

The following errors were reported:
error[E0433]: failed to resolve: use of undeclared crate or module `std`
 --> src/main.rs:5:66
  |
5 | pub unsafe fn allocate(_size: usize, _align: usize) -> *mut u8 { std::ptr::null_mut::<u8>() }
  |                                                                  ^^^ use of undeclared crate or module `std`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
Original diagnostics will follow.

error: cannot mix `bin` crate type with others

error[E0601]: `main` function not found in crate `imcrate`
 --> src/main.rs:5:80
  |
5 | pub unsafe fn allocate(_size: usize, _align: usize) -> *mut u8 { 0 as *mut u8 }
  |                                                                                ^ consider adding a `main` function to `src/main.rs`

error: `#[panic_handler]` function required, but not found

error: language item required, but not found: `eh_personality`
  |
  = note: this can occur when a binary crate with `#![no_std]` is compiled for a target where `eh_personality` is defined in the standard library
  = help: you may be able to compile for a target that doesn't need `eh_personality`, specify a target with `--target` or in `.cargo/config`

For more information about this error, try `rustc --explain E0601`.
warning: `0 as *mut _` detected
 --> src/main.rs:5:66
  |
5 | pub unsafe fn allocate(_size: usize, _align: usize) -> *mut u8 { 0 as *mut u8 }
  |                                                                  ^^^^^^^^^^^^ help: try: `std::ptr::null_mut::<u8>()`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr
  = note: requested on the command line with `-W clippy::zero-ptr`

error: could not compile `imcrate` due to 4 previous errors

Version

rustc 1.67.0-nightly (c97b539e4 2022-11-30)
binary: rustc
commit-hash: c97b539e408ea353f4fde2f9251d598291fec421
commit-date: 2022-11-30
host: x86_64-unknown-linux-gnu
release: 1.67.0-nightly
LLVM version: 15.0.4

Additional Labels

No response

@matthiaskrgr matthiaskrgr added C-bug Category: Clippy is not doing the correct thing I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied I-false-positive Issue: The lint was triggered on code it shouldn't have labels Dec 1, 2022
bors added a commit that referenced this issue Dec 5, 2022
Fix `zero_ptr` suggestion for `no_std` crates

fixes #10017

---

changelog: [`zero_ptr`]: Now suggests `core::` paths for `no_std` crates
[#10023](#10023)
@bors bors closed this as completed in 4129054 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant