Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero_ptr suggestion for no_std crates #10023

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix zero_ptr suggestion for no_std crates #10023

merged 1 commit into from
Dec 6, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Dec 2, 2022 •
edited by xFrednet
Loading

fixes #10017

changelog: Sugg: [zero_ptr]: Now suggests core:: paths for no_std crates
#10023

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2022

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 2, 2022
@xFrednet
Copy link
Member

xFrednet commented Dec 2, 2022

The CI failed due to clippy::module_name_repetitions. Off-topic, but do we maybe want to move that lint to restriction I almost always enable that one ^^

I'll try to review this over the weekend, otherwise early next week :)

@xFrednet
Copy link
Member

xFrednet commented Dec 5, 2022

Excellent, thank you for the update!

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 5, 2022

📌 Commit 6ba2cda has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 5, 2022

⌛ Testing commit 6ba2cda with merge fc97c4c...

bors added a commit that referenced this pull request Dec 5, 2022
@bors
Auto merge of #10023 - Jarcho:issue_10017, r=xFrednet
fc97c4c 
Fix `zero_ptr` suggestion for `no_std` crates

fixes #10017

---

changelog: [`zero_ptr`]: Now suggests `core::` paths for `no_std` crates
[#10023](#10023)
@bors
Copy link
Collaborator

bors commented Dec 5, 2022

💔 Test failed - checks-action_test

@xFrednet xFrednet added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 6, 2022
@xFrednet
Copy link
Member

xFrednet commented Dec 6, 2022

@bors retry

@bors
Copy link
Collaborator

bors commented Dec 6, 2022

⌛ Testing commit 6ba2cda with merge 4129054...

@bors
Copy link
Collaborator

bors commented Dec 6, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 4129054 to master...

@bors bors merged commit 4129054 into rust-lang:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FP zero_ptr in no_std contest
4 participants
@Jarcho @rustbot @xFrednet @bors