New lint: detect unnecessary struct building #10489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
issue-10476
branch
3 times, most recently
from
b1ea128
to
ce3937c
Compare
|
☔ The latest upstream changes (presumably #10481) made this pull request unmergeable. Please resolve the merge conflicts. |
samueltardieu
force-pushed
the
issue-10476
branch
from
ce3937c
to
0e47ff5
Compare
|
☔ The latest upstream changes (presumably #10483) made this pull request unmergeable. Please resolve the merge conflicts. |
samueltardieu
force-pushed
the
issue-10476
branch
from
0e47ff5
to
afc939d
Compare
|
I'll review this in this week. |
giraffate
reviewed
Mar 23, 2023
| /// let b = a; | ||
| /// ``` | ||
| #[clippy::version = "1.70.0"] | ||
| pub UNNECESSARY_STRUCT, |
There was a problem hiding this comment.
This lint detects an unnecessary struct initialization, so, for example, how about the name UNNCESSARY_STRUCT_INITIALIZATION?
There was a problem hiding this comment.
Good idea. Fixed.
samueltardieu
force-pushed
the
issue-10476
branch
from
afc939d
to
3c339ee
Compare
samueltardieu
force-pushed
the
issue-10476
branch
from
3c339ee
to
d7d3dbf
Compare
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10476.
Running this lint on the top 500 crates produced one hit (in
rust-lang/rust-bindgen) and a PR has been submitted there.changelog: [
unnecessary_struct_initialization]: new lint