Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unnecessary_struct_initialization to nursery #10552

Merged

Conversation

Alexendoo
Copy link
Member

changelog: none, assuming it makes into the same release as #10489

Mostly because of #10547 but there is also #10548

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 26, 2023
@flip1995
Copy link
Member

flip1995 commented Mar 27, 2023

Thanks!

@bors r+

Side note: I find this lint a bit weird in the first place. S { ..a } is not really a syntax Rust beginners are aware of IMO. So if someone uses this unusual way to initialize a struct, there is probably a good reason why they didn't use just a. The only other reason I can think of where this could happen is during a refactor removing a struct field. But then again, wouldn't you already notice this during the refactor? 🤔

@bors
Copy link
Collaborator

bors commented Mar 27, 2023

📌 Commit a6f56cb has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 27, 2023

⌛ Testing commit a6f56cb with merge 5698f43...

@bors
Copy link
Collaborator

bors commented Mar 27, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 5698f43 to master...

@bors bors merged commit 5698f43 into rust-lang:master Mar 27, 2023
@Alexendoo Alexendoo deleted the unnecessary-struct-initialization-nursery branch March 27, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants