Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emit_unused_delims_expr ICE #105004

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix emit_unused_delims_expr ICE #105004

merged 1 commit into from
Dec 6, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Nov 28, 2022

Fixes #104897

This is also related to #104433.

@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 28, 2022
}
let mut visitor = ErrExprVisitor { has_error: false };
visitor.visit_expr(value);
if visitor.has_error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a comment here explaining why we do this check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a comment.

fmt

add a comment
@wesleywiser
Copy link
Member

Thanks @TaKO8Ki!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit 5c7278a has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104898 (Put all cached values into a central struct instead of just the stable hash)
 - rust-lang#105004 (Fix `emit_unused_delims_expr` ICE)
 - rust-lang#105174 (Suggest removing struct field from destructive binding only in shorthand scenario)
 - rust-lang#105250 (Replace usage of `ResumeTy` in async lowering with `Context`)
 - rust-lang#105286 (Add -Z maximal-hir-to-mir-coverage flag)
 - rust-lang#105320 (rustdoc: simplify CSS selectors on top-doc and non-exhaustive toggles)
 - rust-lang#105349 (Point at args in associated const fn pointers)
 - rust-lang#105362 (Cleanup macro-expanded code in `rustc_type_ir`)
 - rust-lang#105370 (Remove outdated syntax from trait alias pretty printing)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b29a4f9 into rust-lang:master Dec 6, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: Found a push without a pop / Span must not be empty and have no suggestion
4 participants