Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest removing struct field from destructive binding only in shorthand scenario #105174

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Suggest removing struct field from destructive binding only in shorthand scenario #105174

merged 1 commit into from
Dec 6, 2022

Conversation

chenyukang
Copy link
Member

Fixes #105028

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2022

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2022
@eholk
Copy link
Contributor

eholk commented Dec 6, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit 0e24cee has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2022
@bors
Auto merge of rust-lang#105378 - matthiaskrgr:rollup-fjeorw5, r=matth…
b28d30e 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104898 (Put all cached values into a central struct instead of just the stable hash)
 - rust-lang#105004 (Fix `emit_unused_delims_expr` ICE)
 - rust-lang#105174 (Suggest removing struct field from destructive binding only in shorthand scenario)
 - rust-lang#105250 (Replace usage of `ResumeTy` in async lowering with `Context`)
 - rust-lang#105286 (Add -Z maximal-hir-to-mir-coverage flag)
 - rust-lang#105320 (rustdoc: simplify CSS selectors on top-doc and non-exhaustive toggles)
 - rust-lang#105349 (Point at args in associated const fn pointers)
 - rust-lang#105362 (Cleanup macro-expanded code in `rustc_type_ir`)
 - rust-lang#105370 (Remove outdated syntax from trait alias pretty printing)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 90d84ce into rust-lang:master Dec 6, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eholk eholk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

unused_variable suggets removing struct field from destructive binding which obv. does not work like this
4 participants
@chenyukang @rustbot @eholk @bors